From nobody Tue Aug 27 21:09:31 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WtgCr6FVGz5Jw9g for ; Tue, 27 Aug 2024 21:09:44 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WtgCr4VmCz4w5G for ; Tue, 27 Aug 2024 21:09:44 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-42817bee9e8so50831625e9.3 for ; Tue, 27 Aug 2024 14:09:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724792983; x=1725397783; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NX4IbqHfa5327H4urDGdUF5Df6RypuG+A49oO2gSCpA=; b=m3dRTnThDkq/a1QIo7M/hJ2EVbreS4SNgRGqfAcECIR9H1EyqKCDIr6mVTjmNm9SLq iU7tINvFdbqWKIBdqrabe5B6Wg8c60Tb9Pjl0dH4gtNJtJ+Cl9+kddbZNpD5T7Cfcmk5 xERhbxBmRxffwR4Co9mXRHjHQQT0dRm2uDUi3gsjPIQXF0RtG0kC6j03rwWpBoHjlzj1 UJyZ6b2zFGrkIvQPDfNcOQCw5sU2DVIwlcJ6B6WsT8MrlVQqxTKpNmF0ENkRQHcLGvqx /9/fOfaoP6iI247heZLlRUzSvTWW7b8NTi8qmA/fWKJ6cdHItmf2FF/K6IOR5h2mQ+m7 hvzg== X-Forwarded-Encrypted: i=1; AJvYcCVQ8d2UKIbTQEb4rHBmQn4G4Xfh7TCbOWxxkczAlA6oYCCPL/cv1Fzl67Ssn2DQ3dE6Q6lC4X5xk1jdEUEPVQETw8SB@freebsd.org X-Gm-Message-State: AOJu0YxCKPyxOh0CaNO0zf4flfVdBxkX5cLoN8YujRFJM5BHeTwsJwVB w3gGpGw4SUUOszbI2rJOf4hkyVItr8De2WBIme+aDsOaPZg54sSAOOHiMPUJHt97VtY6zuDEUFq H X-Google-Smtp-Source: AGHT+IFOFGcAcKayBRN3Rmt/3D4+0jlq7VbvU3Y47mQM9pQGHeX775vuhvB9DToR/FUSwGuWQwRqKg== X-Received: by 2002:a05:600c:3514:b0:426:51dc:f6cd with SMTP id 5b1f17b1804b1-42acd57a01dmr108122495e9.18.1724792982617; Tue, 27 Aug 2024 14:09:42 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.201]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42abed8b86bsm234115435e9.4.2024.08.27.14.09.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Aug 2024 14:09:41 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: git: fe66e4caf456 - main - rangelock: Disable cheat mode by default From: Jessica Clarke In-Reply-To: <202408272038.47RKc6Ga049071@gitrepo.freebsd.org> Date: Tue, 27 Aug 2024 22:09:31 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <9CF133C9-42AD-41EE-961E-FBD76DD5F592@freebsd.org> References: <202408272038.47RKc6Ga049071@gitrepo.freebsd.org> To: Mark Johnston X-Mailer: Apple Mail (2.3776.700.51) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4WtgCr4VmCz4w5G On 27 Aug 2024, at 21:38, Mark Johnston wrote: >=20 > The branch main has been updated by markj: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dfe66e4caf4561ee3349ad7a29cc99761= 08c3b04f >=20 > commit fe66e4caf4561ee3349ad7a29cc9976108c3b04f > Author: Mark Johnston > AuthorDate: 2024-08-27 20:31:25 +0000 > Commit: Mark Johnston > CommitDate: 2024-08-27 20:36:31 +0000 >=20 > rangelock: Disable cheat mode by default >=20 > Cheat mode is incompatible with code which locks multiple ranges in = the > same vnode, with at least one range being write-locked. This can = arise > in kern_copy_file_range(). Until that's handled somehow, avoid the > problem to make the fusefs tests stable. >=20 > PR: 281073 > Fixes: 9ef425e560a9 ("rangelocks: add fast cheating mode") > Reviewed by: kib > Differential Revision: https://reviews.freebsd.org/D46457 > --- > sys/kern/kern_rangelock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/sys/kern/kern_rangelock.c b/sys/kern/kern_rangelock.c > index 14163dd1c782..38449f71a8b7 100644 > --- a/sys/kern/kern_rangelock.c > +++ b/sys/kern/kern_rangelock.c > @@ -66,7 +66,7 @@ > * trylocks are same as normal locks but do not drain. > */ >=20 > -static int rangelock_cheat =3D 1; > +static int rangelock_cheat =3D 0; This probably deserves a comment for why it=E2=80=99s disabled/the risks = of enabling it, and/or some text in the sysctl description? Jess > SYSCTL_INT(_debug, OID_AUTO, rangelock_cheat, CTLFLAG_RWTUN, > &rangelock_cheat, 0, > "");