From owner-svn-src-head@FreeBSD.ORG  Mon Jun 29 08:20:42 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 611BB1065670;
	Mon, 29 Jun 2009 08:20:42 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 3A9108FC0A;
	Mon, 29 Jun 2009 08:20:42 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [65.122.17.41])
	by cyrus.watson.org (Postfix) with ESMTPS id DAC8146B03;
	Mon, 29 Jun 2009 04:20:41 -0400 (EDT)
Date: Mon, 29 Jun 2009 09:20:41 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Andre Oppermann <andre@freebsd.org>
In-Reply-To: <4A486C20.2030307@freebsd.org>
Message-ID: <alpine.BSF.2.00.0906290915510.69417@fledge.watson.org>
References: <200906222308.n5MN856I055711@svn.freebsd.org>
	<4A47CC93.5090908@gmx.de> <4A486C20.2030307@freebsd.org>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	Christoph Mallon <christoph.mallon@gmx.de>, src-committers@freebsd.org
Subject: Re: svn commit: r194672 - in head/sys: kern netinet sys
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Jun 2009 08:20:42 -0000


On Mon, 29 Jun 2009, Andre Oppermann wrote:

>> It seems either the third "if" is redundant (because the condition of first 
>> "if" implies the condition of the third) or one of the conditions is wrong. 
>> Also there should be spaces around the |.
>
> Thank you for the report.  I'm working on fixing and testing all the issues 
> that were raised in the perforce branch to be committed soon after review.

I'd really like to see soreceive_stream() grow support for control mbufs, if 
only by detecting controlp != NULL and calling soreceive_generic(), and having 
the mtouio routing properly detect and free them.  This would allow us to use 
soreceive_stream() with UNIX domain stream sockets, which are used by MySQL 
and see similar performance issues.

Robert N M Watson
Computer Laboratory
University of Cambridge