From owner-freebsd-arm@freebsd.org Tue Jul 14 11:20:29 2015 Return-Path: Delivered-To: freebsd-arm@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0D28099C1DF for ; Tue, 14 Jul 2015 11:20:29 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) by mx1.freebsd.org (Postfix) with ESMTP id E7B3F38E for ; Tue, 14 Jul 2015 11:20:28 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by phabric-backend.isc.freebsd.org (Postfix, from userid 1346) id D91C91EE2; Tue, 14 Jul 2015 11:20:28 +0000 (UTC) Date: Tue, 14 Jul 2015 11:20:28 +0000 To: freebsd-arm@freebsd.org From: "meloun-miracle-cz (Michal Meloun)" Reply-to: D3034+327+45b7a5c19a24c07f@FreeBSD.org Subject: [Differential] [Commented On] D3034: Add BUS_UNMASK_INTR method Message-ID: X-Priority: 3 Thread-Topic: D3034: Add BUS_UNMASK_INTR method X-Herald-Rules: <28>, <31>, <32>, <34> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Njk5OTUyY2Q2NjQxNGE1MDJhNmZkNGQ3MjI0IFWk8Hw= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.20 List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2015 11:20:29 -0000 meloun-miracle-cz added a comment. With full respect, I don’t think that this new bus method is right solution for our problem(s). The proposed bus_unmask_intr() cannot be used from outside of secondary CPUs startup context. It cannot be used for SPI, it cannot be used of PPI after scheduler is started on given core. Why you cannot simply call arm_unmask_irq() directly from driver? REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D3034 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: wma_semihalf.com, emaste, imp, ian, andrew, zbb Cc: freebsd-arm-list, meloun-miracle-cz, imp, andrew, emaste