From owner-dev-commits-src-main@freebsd.org Fri May 21 13:37:17 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1B7EF632B94 for ; Fri, 21 May 2021 13:37:17 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Fmnhr3GXgz4rYx for ; Fri, 21 May 2021 13:37:16 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qv1-xf32.google.com with SMTP id w9so10344432qvi.13 for ; Fri, 21 May 2021 06:37:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CSoPBpu6oONP8gXYJUsYdlHqkhvGXRkgBywH0KGxGMQ=; b=Y4BidaudvW2l0mrPoLk+yjbL2OYtV7t5WYOKFd3rWtmlVUOZ+9q2pp2zq6IuDpL/ZH ZZ6+P1pux5AfEqWgEnN3LxxziPvPJ0eaiTqJ13i4/FUMLFYRyQt0Q0NTKerqX59m9Uc+ J1y1fZro3LtVeLa6UIw/Om5A7qj+79EiwFFceKiTdZgbf7Vrb5ktFj1tGKGOozWDXD7R CUO+264ukfZBf7le8ucdLi6+J+Vq3PKWeR+9bjjfSFxEKZgkYsPgn5Etcy8JDJrQG2oy 7cdMp8XWetx6uxEUy3kWt+wAj0Rivu9uBBOhI26MCq0lA78cde+ahkoyFUPMf0+XsiRn yt8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CSoPBpu6oONP8gXYJUsYdlHqkhvGXRkgBywH0KGxGMQ=; b=RLZAET6SM/3jpKKV6XQVW0wi+OyDMRJy3CJiRr7P/2pzaK19Oas0rYL0gOanDi9AFh xRArkUCRQbe3bSWDRA2/rfMQnXqvJj6+jFKJGSstz5DrgyTPkfKctJkQwIDeEMg6/TDd yP7NG5zWWqBoY0YCwwdZQSIgB8n2n9b5JXY4WAsvIAx1YggQ51GeuEgyvr7/rTYZ6Jba ctCb3qVU1noIaM7SwC4Dq6VclnIveSZaIIO1liFpPZiAC6lHYiSu19MH+ZKBlIGfBJJC Nh/GsF2mf2il4u0L+zUUMuiJ6euR1OlJyUE/dkAAQkFfwFHWNJsoLd9C6yGIHyXYkvIp 5+pw== X-Gm-Message-State: AOAM5312p8wzl5BSPgI9MoajQIevxWnYjOqYl8BNxzmSnDHXvxlDDVH8 QZ30eznlZ2h1ydm4CXzFhjzlKA== X-Google-Smtp-Source: ABdhPJxXQBJVtFYhSr8HzvASkaRKKRX6ZgwMbP50yzWjtEh+7ioqkJveFeYNWHVjiCgfJDv1RNXkQQ== X-Received: by 2002:a05:6214:1921:: with SMTP id es1mr13072594qvb.0.1621604235529; Fri, 21 May 2021 06:37:15 -0700 (PDT) Received: from mutt-hbsd (pool-100-16-224-136.bltmmd.fios.verizon.net. [100.16.224.136]) by smtp.gmail.com with ESMTPSA id o5sm4588447qtl.85.2021.05.21.06.37.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 May 2021 06:37:14 -0700 (PDT) Date: Fri, 21 May 2021 09:37:14 -0400 From: Shawn Webb To: Marcin Wojtas Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: af949c590bd8 - main - Disable stack gap for ntpd during build. Message-ID: <20210521133714.g5qpcs5wd4q27tya@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 14.0-CURRENT-HBSD FreeBSD 14.0-CURRENT-HBSD X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <202105211334.14LDYqoa004343@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="acbqqhcrzins2o5s" Content-Disposition: inline In-Reply-To: <202105211334.14LDYqoa004343@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4Fmnhr3GXgz4rYx X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 May 2021 13:37:17 -0000 --acbqqhcrzins2o5s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 21, 2021 at 01:34:52PM +0000, Marcin Wojtas wrote: > The branch main has been updated by mw: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3Daf949c590bd8a00a5973b5875d= 7e0fa6832ea64a >=20 > commit af949c590bd8a00a5973b5875d7e0fa6832ea64a > Author: Marcin Wojtas > AuthorDate: 2021-05-21 09:29:22 +0000 > Commit: Marcin Wojtas > CommitDate: 2021-05-21 13:33:06 +0000 >=20 > Disable stack gap for ntpd during build. > =20 > When starting, ntpd calls setrlimit(2) to limit maximum size of its > stack. The stack limit chosen by ntpd is 200K, so when stack gap > is enabled, the stack gap is larger than this limit, which results > in ntpd crashing. Would it make sense to update the stack limit enforcement code to take the stack gap into account? I haven't looked at HardenedBSD's stack randomization for a while, but if memory serves correctly, we made that change. Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --acbqqhcrzins2o5s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmCnt4cACgkQ/y5nonf4 4frnvBAApuiHsM1JvQ91oeMnrPWi6Z2vg7mPf8Hdi1UO1MoYHWzKuVvFahVix+w+ YTFVmQl4XO1aHNRb6IFC5uq1VBBFSSCCDNBJJFWqG73ZVjr0ezPQMBTVMVKs65G1 UhA9s719/90O3AcnGstwJ9iTPs7+HcWAie3doCjJaxDDrjTSI+mIuoOcN3mG/vj9 iZ8dwuxbsk1TvYtNzqRlx4hz+ZdcePIEEx46jMLn4zOnTa1c/ae54r+Y+D0J4+cB JJqutQoN+z8PVGBujJs/bgtt7kIVNxuq1HtQS4J/bLqgRaQcghvxNkYhUStkA28x ZOPD55X6UwZswr3i7SH0Dbq6uuyd0opEsPfdqQ6EmWbaCf0gxd6IPvr6VFO7nga5 D74hHuEKUqTsOyPs8PK8mm3nnRPJDlC7GzIFAmj8CiEbdXTXsIWtxt+U3Xa6gcEv Qti3zFUdp8Q4oaN52rkeyegiYBeCNEkeWjM+lEtJBBOWhFVlkcRslVtyEfE5McmY aZoLuE3528rU9AFNt4dS1XuTdkUTtZqVyDTml4ismTybkmvYxRPnSAhiVg2sT3iY 5gOxuzyk+pTKcS59it8AjiHGvsVIjsuxNM885ZJQ+4ojtD3LvRg88+Bx6czXcInG WaUj9GjIJ3oO9y2RrKSSLNT0LpM0bub1IxIPpwTyivDIf5RyHx8= =OVVc -----END PGP SIGNATURE----- --acbqqhcrzins2o5s--