Date: Tue, 24 Oct 2023 13:04:35 -0400 From: Phil Shafer <phil@juniper.net> To: Helge Oldach <75ypz71@oldach.net> Cc: Kristof Provost <kp@freebsd.org>, <src-committers@freebsd.org>, <dev-commits-src-all@freebsd.org>, <dev-commits-src-branches@freebsd.org> Subject: Re: git: 8bfa084a4bf3 - stable/13 - ndp: fix timestamp display output Message-ID: <9A751731-ED68-4823-806A-CB1C7DF3A4D7@juniper.net> In-Reply-To: <202310241244.39OCi1Zl054415@nuc.oldach.net> References: <202310241244.39OCi1Zl054415@nuc.oldach.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Looking at:
- xo_emit("{:tv_sec/%lld}{:tv_usec/%lld}%02d:%02d:%02d.%06u ",
+ xo_emit("{e:tv_sec/%lld}{e:tv_usec/%lld}{d:/%02d:%02d:%02d.%06u} ",
tvp->tv_sec, tvp->tv_usec,
I wonder if, while it makes sense to keep the encoded-only raw data, the =
hr:mn:sc data would also be useful in the encoded styles (JSON,XML)?
Thanks,
Phil
On 24 Oct 2023, at 8:44, Helge Oldach wrote:
> [External Email. Be cautious of content]
>
>
> Kristof Provost wrote on Tue, 24 Oct 2023 14:27:48 +0200 (CEST):
>> The branch stable/13 has been updated by kp:
>>
>> URL: https://urldefense.com/v3/__https://cgit.FreeBSD.org/src/commit/?=
id=3D8bfa084a4bf331b6baf2cc530b9752c4cbe573ad__;!!NEt6yMaO-gk!DiOM9v8cS3N=
mBZU7Rg8KHHB7nfjV6jXCvws459nr40kayMsrO1OWkjeDGtmEsv2bfOuQrimOiUqQPfQ$
>>
>> commit 8bfa084a4bf331b6baf2cc530b9752c4cbe573ad
>> Author: R. Christian McDonald <rcm@rcm.sh>
>> AuthorDate: 2023-10-17 16:57:22 +0000
>> Commit: Kristof Provost <kp@FreeBSD.org>
>> CommitDate: 2023-10-24 07:45:38 +0000
>>
>> ndp: fix timestamp display output
>>
>> The current xo_format string is incorrect. This restores the displ=
ay
>> format prior to libxo-ification work while also explicitly marking=
>> tv_sec and tv_usec as encoded output only.
>
> A couple of other xo_emit formats in ndp had also been damaged by the
> libxo-ification. Please see patch in PR 272749.
>
> Kind regards
> Helge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9A751731-ED68-4823-806A-CB1C7DF3A4D7>