From owner-svn-src-head@FreeBSD.ORG  Thu Jan 23 20:17:55 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 17F3B786;
 Thu, 23 Jan 2014 20:17:55 +0000 (UTC)
Received: from mail-bk0-x235.google.com (mail-bk0-x235.google.com
 [IPv6:2a00:1450:4008:c01::235])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 2735D1631;
 Thu, 23 Jan 2014 20:17:53 +0000 (UTC)
Received: by mail-bk0-f53.google.com with SMTP id my13so628870bkb.40
 for <multiple recipients>; Thu, 23 Jan 2014 12:17:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-type:content-disposition:in-reply-to:user-agent;
 bh=5CK5XlHk+Te8z8qyju2awZXuUPdjX/sjfv9TUOn2QFg=;
 b=h58QPV/2nbDTj4oODHeksFMF44y6mhGXqiNf7RSR+kHWi0EEIyooIR5kdrlHL8+h46
 nqrOgUqARAOpUGaJLXY9zdVemyTKeOlRLg3JTR2y0luUV5aRUaB94c3XjIhUHCZIxA+r
 wTlCJ9hrAi6diG9hNzYnBe40meMqK1SfRZobDS8i7Cvmx01hX/x0aUC4kSucgJ0XIZ21
 H0aGumZ53U+OmXsUY3wSkPVH3X7/kcQ3IDfo9YXLgUsHrX8+lwEwfBT/khxrPKVqju3O
 QzMOYwIsHyc9zD7mGjNuMLM74jb6hulcUPd+tah0SyQyI4dhlMUd0Nl56ftFQjf0qj8S
 ouEw==
X-Received: by 10.205.108.71 with SMTP id eb7mr1610456bkc.129.1390508272477;
 Thu, 23 Jan 2014 12:17:52 -0800 (PST)
Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net.
 [2001:470:1f08:1f7::2])
 by mx.google.com with ESMTPSA id rf10sm173451bkb.3.2014.01.23.12.17.50
 for <multiple recipients>
 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
 Thu, 23 Jan 2014 12:17:51 -0800 (PST)
Date: Thu, 23 Jan 2014 21:17:48 +0100
From: Mateusz Guzik <mjguzik@gmail.com>
To: "Andrey V. Elsukov" <ae@FreeBSD.org>
Subject: Re: svn commit: r261085 - head/sys/geom
Message-ID: <20140123201748.GA26772@dft-labs.eu>
References: <201401231931.s0NJVHKS089308@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <201401231931.s0NJVHKS089308@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Jan 2014 20:17:55 -0000

On Thu, Jan 23, 2014 at 07:31:17PM +0000, Andrey V. Elsukov wrote:
> @@ -122,7 +123,7 @@ geom_alloc_copyin(struct gctl_req *req, 
>  	void *ptr;
>  
>  	ptr = g_malloc(len, M_WAITOK);
> -	nreq->nerror = copyin(uaddr, ptr, len);
> +	req->nerror = copyin(uaddr, ptr, len);
>  	if (!req->nerror)
>  		return (ptr);
>  	if (ptr != NULL)

Is not this if (ptr != NULL) unnecesary?

-- 
Mateusz Guzik <mjguzik gmail.com>