Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 14 Aug 2011 19:14:19 +0100 (BST)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Niclas Zeising <niclas.zeising@gmail.com>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r224842 - head/sys/kern
Message-ID:  <alpine.BSF.2.00.1108141912180.63057@fledge.watson.org>
In-Reply-To: <4E47EF64.2070405@gmail.com>
References:  <201108131603.p7DG3e80023093@svn.freebsd.org> <4E47EF64.2070405@gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

On Sun, 14 Aug 2011, Niclas Zeising wrote:

>>   When falloc() was broken into separate falloc_noinstall() and finstall(),
>>   a bug was introduced in kern_openat() such that the error from the vnode
>>   open operation was overwritten before it was passed as an argument to
>>   dupfdopen().  This broke operations on /dev/{stdin,stdout,stderr}.  Fix
>>   by preserving the original error number across finstall() so that it is
>>   still available.
>
> It might be worth mentioning this in UPDATING or similar, since a kernel 
> built with clang (I haven't tried gcc) during this window will make it 
> impossible to do a buildworld without first rebuilding the kernel with this 
> fix. It also seems to break at least portsnap, and possibly other tools as 
> well.

I've queued an update request for UPDATING to re@.  I'm not sure that the gcc 
case was affected (which is to say: I'm not sure I've seen reports of it), but 
I don't know whether I've specifically tested that case.  I can go back and 
test it, but it seems easiest to instead just advise people to skip those revs 
entirely.

Robert



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1108141912180.63057>