From owner-svn-src-all@FreeBSD.ORG  Sun Aug 14 18:14:20 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 473A9106566C;
	Sun, 14 Aug 2011 18:14:20 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 22EEB8FC13;
	Sun, 14 Aug 2011 18:14:20 +0000 (UTC)
Received: from fledge.watson.org (fledge.watson.org [65.122.17.41])
	by cyrus.watson.org (Postfix) with ESMTPS id AFF8346B0D;
	Sun, 14 Aug 2011 14:14:19 -0400 (EDT)
Date: Sun, 14 Aug 2011 19:14:19 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Niclas Zeising <niclas.zeising@gmail.com>
In-Reply-To: <4E47EF64.2070405@gmail.com>
Message-ID: <alpine.BSF.2.00.1108141912180.63057@fledge.watson.org>
References: <201108131603.p7DG3e80023093@svn.freebsd.org>
	<4E47EF64.2070405@gmail.com>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r224842 - head/sys/kern
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Aug 2011 18:14:20 -0000


On Sun, 14 Aug 2011, Niclas Zeising wrote:

>>   When falloc() was broken into separate falloc_noinstall() and finstall(),
>>   a bug was introduced in kern_openat() such that the error from the vnode
>>   open operation was overwritten before it was passed as an argument to
>>   dupfdopen().  This broke operations on /dev/{stdin,stdout,stderr}.  Fix
>>   by preserving the original error number across finstall() so that it is
>>   still available.
>
> It might be worth mentioning this in UPDATING or similar, since a kernel 
> built with clang (I haven't tried gcc) during this window will make it 
> impossible to do a buildworld without first rebuilding the kernel with this 
> fix. It also seems to break at least portsnap, and possibly other tools as 
> well.

I've queued an update request for UPDATING to re@.  I'm not sure that the gcc 
case was affected (which is to say: I'm not sure I've seen reports of it), but 
I don't know whether I've specifically tested that case.  I can go back and 
test it, but it seems easiest to instead just advise people to skip those revs 
entirely.

Robert