From owner-p4-projects@FreeBSD.ORG Wed Jul 4 15:15:14 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 3A44F16A46D; Wed, 4 Jul 2007 15:15:14 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0F1B116A46C for ; Wed, 4 Jul 2007 15:15:14 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.171]) by mx1.freebsd.org (Postfix) with ESMTP id 9827C13C447 for ; Wed, 4 Jul 2007 15:15:13 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by ug-out-1314.google.com with SMTP id o4so351460uge for ; Wed, 04 Jul 2007 08:15:12 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=G8tALKlD6CKeg76tGTO1tOTcyt9XRnxM8BwoFHDyoAgrkwubf+hNoJrsSCVHRXIXeHKU5UERvxi9XAM2IhZfPtgSMJtHQulOICoSoII2Nn+VrS/QJMlbp3bDcLReniFb5tU/ZGp3+68xj8xPVxmlS5BD7bpqKDUBjVVqIMqlr3E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=NPdB1QXBpd77Hq51jL9gUdU2wBNQ5iz3Dk+tmoUowGLxz4BFKXRCxoe36Yg/Kai62Fak8UwD7rcXOx7wb7La3AJ/5ec1WJ5KVqZOh0U3euwmm874HgPM6kk/vO9hsXOvIQOyKKfjnD72t7cWbDibN+QrJxK1WWHqYLjS+6aZOKc= Received: by 10.78.165.16 with SMTP id n16mr4180452hue.1183562112060; Wed, 04 Jul 2007 08:15:12 -0700 (PDT) Received: by 10.78.97.18 with HTTP; Wed, 4 Jul 2007 08:15:12 -0700 (PDT) Message-ID: <3bbf2fe10707040815u522d3580m445d27d60d58228@mail.gmail.com> Date: Wed, 4 Jul 2007 17:15:12 +0200 From: "Attilio Rao" Sender: asmrookie@gmail.com To: "Rui Paulo" In-Reply-To: <200707040343.l643hQ2i073492@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200707040343.l643hQ2i073492@repoman.freebsd.org> X-Google-Sender-Auth: f07d48201e5c780f Cc: Perforce Change Reviews Subject: Re: PERFORCE change 122829 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jul 2007 15:15:14 -0000 2007/7/4, Rui Paulo : > struct asmc_softc { > - device_t sc_dev; > - struct mtx sc_mtx; > - > - int sc_nfan; > - > - int16_t sms_rest_x; > - int16_t sms_rest_y; > - int16_t sms_rest_z; > - > + device_t sc_dev; > + struct mtx sc_mtx; > + int sc_nfan; > + int16_t sms_rest_x; > + int16_t sms_rest_y; > + int16_t sms_rest_z; > struct sysctl_ctx_list sc_sysctl_ctx; > - struct sysctl_oid *sc_root_tree; > - struct sysctl_oid *sc_fan_tree[ASMC_MAXFANS+1]; > - struct sysctl_oid *sc_temp_tree; > - struct sysctl_oid *sc_sms_tree; > - > - struct asmc_model *sc_model; > - > - int sc_rid; > - struct resource *sc_res; > - void *sc_cookie; > - > - int sms_intrtype; > - struct taskqueue *sms_tq; > - struct task sms_task; > + struct sysctl_oid *sc_root_tree; > + struct sysctl_oid *sc_fan_tree[ASMC_MAXFANS+1]; > + struct sysctl_oid *sc_temp_tree; > + struct sysctl_oid *sc_sms_tree; > + struct asmc_model *sc_model; > + int sc_rid; > + struct resource *sc_res; > + void *sc_cookie; > + int sms_intrtype; > + struct taskqueue *sms_tq; > + struct task sms_task; > }; Members of the same struct should have the same name prefix, in this case you should not mix between sc_ and sms_. Attilio -- Peace can only be achieved by understanding - A. Einstein