From owner-freebsd-hackers@FreeBSD.ORG Wed Mar 12 15:36:47 2014 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 94DFF7F2; Wed, 12 Mar 2014 15:36:47 +0000 (UTC) Received: from mailuogwdur.emc.com (mailuogwdur.emc.com [128.221.224.79]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 3DFAAB7B; Wed, 12 Mar 2014 15:36:46 +0000 (UTC) Received: from maildlpprd53.lss.emc.com (maildlpprd53.lss.emc.com [10.106.48.157]) by mailuogwprd52.lss.emc.com (Sentrion-MTA-4.3.0/Sentrion-MTA-4.3.0) with ESMTP id s2CFahLb027167 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 12 Mar 2014 11:36:45 -0400 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd52.lss.emc.com s2CFahLb027167 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=isilon.com; s=jan2013; t=1394638605; bh=TxLUNAq0+ToJ6xBRdW1InUb2SFc=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:Content-Transfer-Encoding:MIME-Version; b=EWmwowPkw2KDoiNrUyOHdxHZawMxNrvfzIDelGkpBrLpY2IIMhcWtwQeLGSFv9I5I IEgCGwmT4l+/qmrHxwZxSJEvwHA/N9FhsI42EnJVMRU7SCDjS1teis2RnqCG70k94D 0YMsGQsimOdJ10sOwdtT/eCIm4q5/p2Vz6BPxgmQ= X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd52.lss.emc.com s2CFahLb027167 Received: from mailusrhubprd54.lss.emc.com (mailusrhubprd54.lss.emc.com [10.106.48.19]) by maildlpprd53.lss.emc.com (RSA Interceptor); Wed, 12 Mar 2014 11:36:32 -0400 Received: from mxhub13.corp.emc.com (mxhub13.corp.emc.com [128.222.70.234]) by mailusrhubprd54.lss.emc.com (Sentrion-MTA-4.3.0/Sentrion-MTA-4.3.0) with ESMTP id s2CFaVAM001061 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 12 Mar 2014 11:36:31 -0400 Received: from MXHUB106.corp.emc.com (10.253.58.23) by mxhub13.corp.emc.com (128.222.70.234) with Microsoft SMTP Server (TLS) id 8.3.327.1; Wed, 12 Mar 2014 11:36:30 -0400 Received: from MX103CL02.corp.emc.com ([169.254.6.182]) by MXHUB106.corp.emc.com ([10.253.58.23]) with mapi id 14.03.0158.001; Wed, 12 Mar 2014 11:36:31 -0400 From: "Meyer, Conrad" To: Konstantin Belousov , Conrad Meyer Subject: RE: [PATCH 1/5] vm/device_pager.c: dev_pager_alloc: 'size' must be non-zero Thread-Topic: [PATCH 1/5] vm/device_pager.c: dev_pager_alloc: 'size' must be non-zero Thread-Index: AQHPPYjSzQvZ88ne20iosi2VkBm1e5rdhBKAgAASbyU= Date: Wed, 12 Mar 2014 15:36:30 +0000 Message-ID: References: <1394583583-19023-1-git-send-email-conrad.meyer@isilon.com> <1394583583-19023-2-git-send-email-conrad.meyer@isilon.com>, <20140312103009.GT24664@kib.kiev.ua> In-Reply-To: <20140312103009.GT24664@kib.kiev.ua> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.7.176.236] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Sentrion-Hostname: mailusrhubprd54.lss.emc.com X-RSA-Classifications: public X-Mailman-Approved-At: Wed, 12 Mar 2014 15:43:58 +0000 Cc: "freebsd-hackers@freebsd.org" , Jeffrey Roberson X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Mar 2014 15:36:47 -0000 On Wed, Mar 12, 2014 at 3:30 AM, Konstantin Belousov = wrote:=0A= >=0A= > Thank you for the submission, I committed four patches, except this one.= =0A= >=0A= =0A= Thanks!=0A= =0A= >=0A= > On Tue, Mar 11, 2014 at 05:19:39PM -0700, Conrad Meyer wrote:=0A= > > If size is zero, paddr is used uninitialized when assigning=0A= > > object1->pg_color.=0A= > So the issue there is only with non-managed device pager, right ?=0A= > Please note that GEM explicitely initializes color in the constructor.=0A= >=0A= > I do not like the change below, it puts the policy into pager, while=0A= > currently the decision is up to managed pager consumers, e.g. GEM,=0A= > which do the similar check on its own.=0A= >=0A= > I prefer a different way to shut down the warning, please see the=0A= > patch at the end of the message. Does it work for you ?=0A= >=0A= > diff --git a/sys/vm/device_pager.c b/sys/vm/device_pager.c=0A= > index 13491ba..4cd245a 100644=0A= > --- a/sys/vm/device_pager.c=0A= > +++ b/sys/vm/device_pager.c=0A= > @@ -414,6 +414,7 @@ old_dev_pager_ctor(void *handle, vm_ooffset_t size, v= m_prot_t prot,=0A= > * XXX assumes VM_PROT_* =3D=3D PROT_*=0A= > */=0A= > npages =3D OFF_TO_IDX(size);=0A= > + paddr =3D 0; /* Make paddr initialized for the case of size =3D= =3D 0. */=0A= > for (off =3D foff; npages--; off +=3D PAGE_SIZE) {=0A= > if (csw->d_mmap(dev, off, &paddr, (int)prot, &dummy) !=3D= 0) {=0A= > dev_relthread(dev, ref);=0A= =0A= Looks good to me.=0A= =0A= Thanks,=0A= Conrad=