From nobody Thu Mar 13 16:03:23 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZDC302Hc4z5qrn6; Thu, 13 Mar 2025 16:03:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZDC300cW3z3QpG; Thu, 13 Mar 2025 16:03:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741881804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fNixNh5Ev6dzJ6Ujt1XV5z1N3CngL4uJI2dbboCQ7Pw=; b=Q9W/9/ZpBtmI4fNBG8Q4EuxAjZHqUO4cPOfCi0CtnWrQ3ZW2aMJxtFOxPOMKtU87D9Cdr7 8pUByJqXAHtJYIH/lE72pkTR0xwJJ/yalLzXci1cEG6ZptviklWVoYMfvkPPwLPH5pPUAx vAIqizgrllX+UujDePXvYBJeoLdtZyEKCVrjERh11OFqF6dAW8xHAlA8ZFMzY/gtUgRhJq 7GEjqL43VEcfVY/kt0Ea+powNhzyX7laboKpxjVYqvK4P1bqt5LAjPjNCgepHOIkns08RA 9InvyiXwfxeMXbdLGCjD1E0QlHmXEeZmWzGPJ4iGjHrr/vDDKuQ9uJqZb3gpkg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741881804; a=rsa-sha256; cv=none; b=DVYHFalk29iV9ZAe/2H9Xj0VHA3Mz9KYbRKMw7Gr1TCA205TDxMOeUXqYUGAWv9bokL9CY XiJjXM4bnOC1IVZ4Af74vs1UajkwzBmettu7XSwF0Nlh/6vbWrcib1ZtDFNpeBgVw64g/k Wkfznfa0yogTV5qnTSYmDlTl5Uwm0l/LiDCJnAhCrzvmL5SiV1tXY55AXcA3lYOHaOP9lT kQHgeTovISKQVdPIvLLduJ8Rx89dhbtySclpFzpccLX5QX51mCG0qOWFaiBmRNk4XCU0n6 5VFjSj1Mf6kYcab6kF2EHwJaOfj4MZ0Zlf7e8zurqP3DOlXnxK08EGeNomkALg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741881804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fNixNh5Ev6dzJ6Ujt1XV5z1N3CngL4uJI2dbboCQ7Pw=; b=MUFCIgdTF8jwasqrCxdXHV+lkuCLOzbEiB0fctLW8h/bYfl6n2VrN1u+5CtKQBxe97rPQB 0JcU0gZ3JTpWGOWkUBBWZ4TmUSeYpneHx7uZgD9MGmeW5d2oqA5sYokXd29XHs1q+BHFo7 0lHFWqLih7By/ZyEFUYWGxswxk1nIwj8iWOIeHO1Qa/GjFzLAs7S4IMBB9C2ojn0Pun1Lj VcKrm94JZ4ofOAdFOKTxLOSkH3e0KEFNJxm72JzUbl8N3rIi07cG1Zguh1QVTZjbqmhzjS WLoXcRgOvJNacTX3B2AgW9Ovtc8F05E27kmzjweF/oy398ra7zsz+qQ9xX9D8Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZDC2z6sbCz14j6; Thu, 13 Mar 2025 16:03:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52DG3NWQ048827; Thu, 13 Mar 2025 16:03:23 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52DG3Neu048824; Thu, 13 Mar 2025 16:03:23 GMT (envelope-from git) Date: Thu, 13 Mar 2025 16:03:23 GMT Message-Id: <202503131603.52DG3Neu048824@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 89491b1edb34 - main - mlx5en: stop arbitrary limiting max wqe size List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 89491b1edb3438ebce84e17fdb6c1acab35df601 Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=89491b1edb3438ebce84e17fdb6c1acab35df601 commit 89491b1edb3438ebce84e17fdb6c1acab35df601 Author: Konstantin Belousov AuthorDate: 2025-02-27 01:54:31 +0000 Commit: Konstantin Belousov CommitDate: 2025-03-13 16:01:17 +0000 mlx5en: stop arbitrary limiting max wqe size Since the times the driver accepts s/g receive buffers, there is no sense in trying to use pre-existing mbuf clusters sizes. The only possible optimization is to use full page size if wqe size is greater than MCLBYTES. Reviewed by: Ariel Ehrenberg , Slava Shwartsman Sponsored by: NVidia networking MFC after: 1 week --- sys/dev/mlx5/mlx5_en/mlx5_en_main.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c index d69d2e433c9c..8b2acddb869a 100644 --- a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c +++ b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c @@ -2321,17 +2321,7 @@ mlx5e_get_wqe_sz(struct mlx5e_priv *priv, u32 *wqe_sz, u32 *nsegs) r = priv->params.hw_lro_en ? priv->params.lro_wqe_sz : MLX5E_SW2MB_MTU(if_getmtu(priv->ifp)); - if (r > MJUM16BYTES) - return (-ENOMEM); - - if (r > MJUM9BYTES) - r = MJUM16BYTES; - else if (r > MJUMPAGESIZE) - r = MJUM9BYTES; - else if (r > MCLBYTES) - r = MJUMPAGESIZE; - else - r = MCLBYTES; + r = r > MCLBYTES ? MJUMPAGESIZE : MCLBYTES; /* * n + 1 must be a power of two, because stride size must be.