From owner-svn-src-all@freebsd.org Tue Feb 27 15:34:13 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E11A5F2FF65; Tue, 27 Feb 2018 15:34:12 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-lf0-f44.google.com (mail-lf0-f44.google.com [209.85.215.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 574757E2EF; Tue, 27 Feb 2018 15:34:12 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-lf0-f44.google.com with SMTP id i80so8824891lfg.5; Tue, 27 Feb 2018 07:34:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=pJ//gQHM8aHDQ5zIeoaul3cOuU5dFR80tHM2LtwwqDg=; b=uVzW45MoLeJjfxrTotbaZvKqydMw+mG0r45QdWjDE056qxiNjfITfbVS0KplMqqpoh mE0tf8d6y7EZicwAl/N481k513fKACmZdsQEky7bK1qIgh0KREtv0HZGJKSph0HMm3pd 8chGu1cQx7nQH77+D7G8YBojOXwiyEakgCOmcYRU+QOHR09kYwxBREdQGvbLOlKQGHQG wFgzKRzXvUe+qBrl9szqxTxZO8+A4SQnQ5w2joH1erNlNBabSXtG2DPZUTqbIj/oBhgB oO18cBFRNI2p32CHUGMGzRo/76nSewqNHNYEweqCKuQ7snlSXQLYDim4xL7vCSJWsbg4 6dLg== X-Gm-Message-State: APf1xPBPxyMB3Uzop9gTOmHj5lr7K5UQ/IMjLznpZTSrPho+qxH4q7M1 KCrG7SVLvf6GfREUPIQS8l895eIy X-Google-Smtp-Source: AG47ELvq8Lm7gxFKK5evkQ/Dq2+Lj6jtLviRBzeRkBZxT/KMBHmaJRotv9V/C1H7F79uVpUa/uJC/g== X-Received: by 10.46.104.26 with SMTP id c26mr10072434lja.43.1519745650284; Tue, 27 Feb 2018 07:34:10 -0800 (PST) Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com. [209.85.215.52]) by smtp.gmail.com with ESMTPSA id e27sm2598443lfb.20.2018.02.27.07.34.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Feb 2018 07:34:10 -0800 (PST) Received: by mail-lf0-f52.google.com with SMTP id t204so28145036lff.9; Tue, 27 Feb 2018 07:34:10 -0800 (PST) X-Received: by 10.25.181.147 with SMTP id g19mr11364760lfk.47.1519745650028; Tue, 27 Feb 2018 07:34:10 -0800 (PST) MIME-Version: 1.0 Received: by 10.46.54.1 with HTTP; Tue, 27 Feb 2018 07:33:49 -0800 (PST) In-Reply-To: References: <201802260316.w1Q3G4vc022314@repo.freebsd.org> From: Kyle Evans Date: Tue, 27 Feb 2018 09:33:49 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r330004 - in head/stand: . arm efi forth i386 mips powerpc sparc64 To: Warner Losh Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2018 15:34:13 -0000 n Tue, Feb 27, 2018 at 9:28 AM, Kyle Evans wrote: > On Sun, Feb 25, 2018 at 9:16 PM, Warner Losh wrote: >> Author: imp >> Date: Mon Feb 26 03:16:04 2018 >> New Revision: 330004 >> URL: https://svnweb.freebsd.org/changeset/base/330004 >> >> Log: >> Add NO_OBJ to those directories that don't make anything. >> >> For directories that don't many anything, add NO_OBJ=t just before we >> include bsd.init.mk. This prevents them from creating an OBJ >> directory. In addition, prevent defs.mk from creating the machine >> related links in these cases. They aren't needed and break, at least >> on stable, the read-only src tree build. >> > > Any objection to also removing efi from i386 SUBDIR? It seems silly > to be explicitly adding it when we know nothing here is applicable and > it's going to take some amount of work to get there. In fact, this block [1] feels wrong, too... why are we adding efi to SUBDIR for arch's that don't support it? I understand the GCC checks, but libefi, loader, and boot1 are the main bits of efi/, why are these stuck behind MACHINE_CPUARCH checks? [1] https://svnweb.freebsd.org/base/head/stand/efi/Makefile?view=markup#l17