From owner-freebsd-current@freebsd.org Sun Jul 8 23:13:13 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F32F61041B94 for ; Sun, 8 Jul 2018 23:13:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22a.google.com (mail-io0-x22a.google.com [IPv6:2607:f8b0:4001:c06::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9206C72074 for ; Sun, 8 Jul 2018 23:13:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22a.google.com with SMTP id q19-v6so15442631ioh.11 for ; Sun, 08 Jul 2018 16:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=2RX1Lzcbr7wA3pWz0XncdmwK5+lARUSbZdgquy74hGY=; b=RbIlCEjG1iAm/DzipFGNjI/VXZplmW/nNGXrcBgNe1Z9nooA7VBj4XR+MLnJ+9qInW IvibGKXWfdbeZX2IvQcA2f49LzRKJUaCl8yqJ8p5Yl1Tc3SafmGTMcDNvWbVhnS4hevb 0e3tj0nhRxgnOsRT/XikLGhbxTbPLJ8ZvtYUvXJtYUKzl6NvUIxOLDXFEyWSVjy8WSXt BEyUArQE7+trlh6oAr4sEig0S1gUHDEVIeY3p5/Ths3TevNOfz7zY01A4VNfQI79S1MC UQXW/N6awJiV+7tpFwMWzzHljnMzVuTZ+Cv3YjqwQ5sh9SS9Z1qKNXcz+mRrDVe2/ati 8+4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=2RX1Lzcbr7wA3pWz0XncdmwK5+lARUSbZdgquy74hGY=; b=mSKzwoZQaBW0x2x5JXxhjXz416PAnw6paCdeoVo9IIZi4cPxYzi2MKRQBvqwESOShm RVhIIEcyr/fJIcX3e+R266aSLIq7azt7QMGNfPMCM85Dt3TRSyCFc1XMsbLvK/Rc37J7 2S5cNoDkk0LoC9IqyBe6VWWfWkRMlhQjKEjiWJEi4uP9eqd6AffP+wYBx4+trnfOkb4u f57ahCqLhR7nnKUaTE0LZ2ujJ4pbEtW+4+BZRpUZybKXrEj1OwQRk2D0ZrEO0uVzfJsP Lo4MbyOYpbHJ2dJY54TRhxSd1J2UytaKgMeUqV8JgZ2otdLEOS3PdphQ4Qz3cmncUUf7 pS5g== X-Gm-Message-State: APt69E2KKyRHamMQFcGET2urtwCS4DdIK3ihHUXsPJC6UQ9qJlvOqfeD 2fvoEWv1Ou2BrQDIADXJBKg3XzS5f+D1s7Mv7YZjmg== X-Google-Smtp-Source: AAOMgpea1AYyeyOOpJ+Ly16NqrcOIGLnFqZY98R1LxgWb0k3A9/PcXl/q4gsb/vKFj7Ckm66E9cjZIW8tuPhNmJ157E= X-Received: by 2002:a6b:d004:: with SMTP id x4-v6mr14910023ioa.299.1531091591616; Sun, 08 Jul 2018 16:13:11 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:1183:0:0:0:0:0 with HTTP; Sun, 8 Jul 2018 16:13:11 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <6EA9A549-7508-467C-BED2-AF0C136C752D@yahoo.com> References: <6EA9A549-7508-467C-BED2-AF0C136C752D@yahoo.com> From: Warner Losh Date: Sun, 8 Jul 2018 17:13:11 -0600 X-Google-Sender-Auth: 5MkCQyWNXFL1Z03IhFq7TkM1_Zc Message-ID: Subject: Re: -r336099 and later: broke ci.freebsd.prg's FreeBSD-head-amd64-build To: Mark Millard Cc: FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jul 2018 23:13:13 -0000 Yea, there's a stray space in that string. r336114 should fix that. Warner On Sun, Jul 8, 2018 at 4:50 PM, Mark Millard wrote: > https://ci.freebsd.org/job/FreeBSD-head-amd64-build/9386/consoleText > shows: > > ===> zlib (install) > install -T release -o root -g wheel -m 555 zlib.ko > /usr/obj/usr/src/amd64.amd64/release/dist/kernel/boot/kernel/ > install -T debug -o root -g wheel -m 555 zlib.ko.debug > /usr/obj/usr/src/amd64.amd64/release/dist/kernel/usr/lib/ > debug/boot/kernel/ > kldxref /usr/obj/usr/src/amd64.amd64/release/dist/kernel/boot/kernel > kldxref: Parse error of description string U16:vendor; U16:device > *** Error code 1 > > Stop. > make[4]: stopped in /usr/src/sys/modules > > > Note the "U16:vendor; U16:device" reference and such text in > the below (and other check-ins after it). . . > > > Author: imp > Date: Sun Jul 8 20:39:38 2018 > New Revision: 336099 > URL: > https://svnweb.freebsd.org/changeset/base/336099 > > > Log: > Add PNP info to PCI attachment of ena driver > . . . > > Modified: > head/sys/dev/ena/ena.c > head/sys/dev/ena/ena.h > > Modified: head/sys/dev/ena/ena.c > ============================================================ > ================== > --- head/sys/dev/ena/ena.c Sun Jul 8 20:39:23 2018 (r336098) > +++ head/sys/dev/ena/ena.c Sun Jul 8 20:39:38 2018 (r336099) > @@ -3947,6 +3947,8 @@ static driver_t ena_driver = { > > devclass_t ena_devclass; > DRIVER_MODULE(ena, pci, ena_driver, ena_devclass, 0, 0); > +MODULE_PNP_INFO("U16:vendor; U16:device", pci, ena, ena_vendor_info_array, > + sizeof(ena_vendor_info_array[0]), nitems(ena_vendor_info_array) - 1); > MODULE_DEPEND(ena, pci, 1, 1, 1); > MODULE_DEPEND(ena, ether, 1, 1, 1); > > . . . > > > === > Mark Millard > marklmi at yahoo.com > ( dsl-only.net went > away in early 2018-Mar) > >