From owner-freebsd-net@FreeBSD.ORG Thu Jan 22 19:17:27 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8478667E for ; Thu, 22 Jan 2015 19:17:27 +0000 (UTC) Received: from mail-ig0-f169.google.com (mail-ig0-f169.google.com [209.85.213.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47E14801 for ; Thu, 22 Jan 2015 19:17:27 +0000 (UTC) Received: by mail-ig0-f169.google.com with SMTP id hl2so20019686igb.0 for ; Thu, 22 Jan 2015 11:17:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-type:content-disposition:user-agent; bh=mXvRVa+dt9j5/MHau7LLDjPQK2tXJsEBeCxuK6jfWxk=; b=IfPKICW+h2UsSAbZbigMuZhM/BxilNZCbDjqjweJ2bJiKDoa16sRVSn1ga2mpscHVR BxP0NNLRU3NiIJt3YTpeDBCsESRQkVFVfyHqNYBUeE1ycNWq+/KMTiQPwSWhjo85CorS 75HjCJEhaeynF5h5qgvWfIt7IdE+xdv3i/XGhKxvjKa8SvhPC6Bm4Zdl+g5EcMHRuwJ2 +pRnicYOEliRZ++X1ZGgvwOlID8DgVumsHGLsWUdqDW1NdLIXl6nE1EW2EzogHpIC0KD RvZ1XKeVTAtK74nM25r+QUfwMtdH8xMCYBMNQ2IZwJDqF0kDfBxS7Ka3xTdmnVHUHokO d86g== X-Gm-Message-State: ALoCoQlHBkgepoOW9oFWy3lQ4aG4HlFn52oKoieiMm8K49b/XglvRAgnieXB/xkSbrauQ+BorAIV X-Received: by 10.50.111.10 with SMTP id ie10mr14675779igb.15.1421954245980; Thu, 22 Jan 2015 11:17:25 -0800 (PST) Received: from sol.firepipe.net (c-50-183-92-30.hsd1.co.comcast.net. [50.183.92.30]) by mx.google.com with ESMTPSA id fr4sm3523174igd.4.2015.01.22.11.17.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Jan 2015 11:17:25 -0800 (PST) Date: Thu, 22 Jan 2015 12:17:23 -0700 From: Will Andrews To: freebsd-net@freebsd.org Subject: MFC of if_lagg flowid changes (r272386)? Message-ID: <20150122191722.GB49380@sol.firepipe.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TakKZr9L6Hm6aLOc" Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Cc: adrian@freebsd.org, emax@freebsd.org, hrs@freebsd.org, asomers@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jan 2015 19:17:27 -0000 --TakKZr9L6Hm6aLOc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, Please see: https://svnweb.freebsd.org/base?view=3Drevision&revision=3D272386 This change removes sysctl nodes that were added during lacp_attach(), which causes a lock order reversal (sleepable lock while holding non-sleepable). These sysctl nodes arrived in: https://svnweb.freebsd.org/base?view=3Drevision&revision=3D253687 Here is a bug report about the LOR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D188997 I propose to MFC r272386 to eliminate the bug. However, it also eliminates sysctl nodes that were added to control lagg behavior. My understanding is that these sysctls weren't intended to be publicly used, and consequently they aren't documented anywhere. Any objections? Thanks! --=20 wca --TakKZr9L6Hm6aLOc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlTBTMEACgkQF47idPgWcsXRFACfc05RH6X5jjKVPZsEAzmOC1YF b/AAn1cBsmXvF2D+jGNlDTYCZiWcmFEW =TdhX -----END PGP SIGNATURE----- --TakKZr9L6Hm6aLOc--