From nobody Mon Feb 9 18:48:02 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f8txH1gPWz6RrJh for ; Mon, 09 Feb 2026 18:48:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f8txG5HCtz4650 for ; Mon, 09 Feb 2026 18:48:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770662882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RNs5OPEesGK78Od5K6uQP2//raXJTGnTdt2Zp2jh+gQ=; b=C+SEVTPp0B9fPXVvTZYjvr0eioUZb1f/J55Ri8/LAz7UohEa/5j2v3jxF1F0nEImFp6tsd 5I0c+ifH5SO/Mz1F9Ik+rqqoAO1XGfmPCI+1yvrPANnK7Yyyn3sZWQMP/VApLN0WQUzE21 aQBpuo8PhmRC5Q/WM64LbBfgoI/2Z4bw1GZENPglECO7AhtyoQ9oKE+wWSJBc3AFIrKvbL l025EUl0I2mWB5aTHMjGnKbcYGuzPJg5os7dux9xxdkaGdzkvX8nL+upjQxby6/vgsuIKu sqgdJZ4bqQvtd0olMQoaR70mCrEUiCYG32JWcrRoNNUd0nNY7RZ5Rww/rQp5LQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770662882; a=rsa-sha256; cv=none; b=tuTAOAe+WFoZIpLeeSc10fdTddtwbwKaTUG7o7zMa7Bxd6xMnK/3CtUSk0C3eCwql811z8 SRLnPPGpQ+WU2QU0PHAeitqO7ksdTOCKZaq9KXynzYu+czpzdn0dhpu2pvDTUEKeakVUQE JUcajVQIq3PjQ5ok8se7S6oEK0xbdwZwprt2IspALMypVOVFpZJURySwfNC9OZcaPPFj6U kc7gMIjo/5/KkkEnQg3GuCeVzXtY9n/p4o7OYGH3zjgsSaZnlenvLOFnZC0YBlrGVWKBLZ keLTOAKVjEvYxkxaNhHOnh7aFyamqw3oaakXmew8pEkTSotH9ilCA8XIKXW5lw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770662882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RNs5OPEesGK78Od5K6uQP2//raXJTGnTdt2Zp2jh+gQ=; b=CzYkSZAfFRqvNskGi7OLGE2BuCzAe793gEqAnW3K9rWwDNNdIiabwj1qMSBjmVdfyQzxwF LIWJfHnAmhf37yOHKZPN4Jfd6NERCCs9mLYEL+38L0JYtzKB+fduSgBni114C4+efZnhD7 wYvjhLQ1LP3L0zrO0tBwqvsG1D4iCVyLRmv+KSyi1/8eGbVHUZUFJ8/K3bnaBe5K68QaCH VjG7xsfT9F1/Sq0RZsqTam7aXQKPzibyZBmKrzc/AY0SOdjI+Cbo0i9/uxguNC0NbJNn/g 0kET9H+XhqkE/QRzXEKyaqWaUtVocT4hpqijZIkj1k9moU1Rf8nBc0wtKn/npQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f8txG4bM6zldC for ; Mon, 09 Feb 2026 18:48:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 33f25 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 09 Feb 2026 18:48:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 8066b8923ebf - main - kern/vfs_unmount.c: promote flags to uint64_t List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8066b8923ebfd438dc8cb840d2f57066f4daa45d Auto-Submitted: auto-generated Date: Mon, 09 Feb 2026 18:48:02 +0000 Message-Id: <698a2be2.33f25.70bdf17b@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=8066b8923ebfd438dc8cb840d2f57066f4daa45d commit 8066b8923ebfd438dc8cb840d2f57066f4daa45d Author: Konstantin Belousov AuthorDate: 2026-02-09 03:11:15 +0000 Commit: Konstantin Belousov CommitDate: 2026-02-09 18:47:18 +0000 kern/vfs_unmount.c: promote flags to uint64_t to prevent sign-extension, causing unexpected flags to be passed to dounmount(). The mnt_flags and MNT_* constants are 64bit wide. Suggested and reviewed by: jah Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D55197 --- sys/compat/linux/linux_file.c | 2 +- sys/kern/vfs_mount.c | 4 ++-- sys/sys/syscallsubr.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/compat/linux/linux_file.c b/sys/compat/linux/linux_file.c index 96326b894d05..ca089585bb95 100644 --- a/sys/compat/linux/linux_file.c +++ b/sys/compat/linux/linux_file.c @@ -1213,7 +1213,7 @@ linux_oldumount(struct thread *td, struct linux_oldumount_args *args) int linux_umount(struct thread *td, struct linux_umount_args *args) { - int flags; + uint64_t flags; flags = 0; if ((args->flags & LINUX_MNT_FORCE) != 0) { diff --git a/sys/kern/vfs_mount.c b/sys/kern/vfs_mount.c index 240bf5451a84..2237fcc6b423 100644 --- a/sys/kern/vfs_mount.c +++ b/sys/kern/vfs_mount.c @@ -1720,11 +1720,11 @@ int sys_unmount(struct thread *td, struct unmount_args *uap) { - return (kern_unmount(td, uap->path, uap->flags)); + return (kern_unmount(td, uap->path, (unsigned)uap->flags)); } int -kern_unmount(struct thread *td, const char *path, int flags) +kern_unmount(struct thread *td, const char *path, uint64_t flags) { struct nameidata nd; struct mount *mp; diff --git a/sys/sys/syscallsubr.h b/sys/sys/syscallsubr.h index e2bbbc188553..35e2b771cbe7 100644 --- a/sys/sys/syscallsubr.h +++ b/sys/sys/syscallsubr.h @@ -403,7 +403,7 @@ int kern_wait6(struct thread *td, enum idtype idtype, id_t id, int *status, int kern_writev(struct thread *td, int fd, struct uio *auio); int kern_socketpair(struct thread *td, int domain, int type, int protocol, int *rsv); -int kern_unmount(struct thread *td, const char *path, int flags); +int kern_unmount(struct thread *td, const char *path, uint64_t flags); int kern_kexec_load(struct thread *td, u_long entry, u_long nseg, struct kexec_segment *seg, u_long flags);