From owner-freebsd-ports Thu Dec 14 9:26:28 2000 From owner-freebsd-ports@FreeBSD.ORG Thu Dec 14 09:26:24 2000 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from rover.village.org (rover.village.org [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 9379237B404; Thu, 14 Dec 2000 09:26:22 -0800 (PST) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.0/8.11.0) with ESMTP id eBEHQKs86680; Thu, 14 Dec 2000 10:26:21 -0700 (MST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id KAA48452; Thu, 14 Dec 2000 10:26:20 -0700 (MST) Message-Id: <200012141726.KAA48452@harmony.village.org> To: Will Andrews Subject: Re: cvs commit: ports/databases/gigabase distinfo Cc: Peter Pentchev , ports@FreeBSD.org, kris@FreeBSD.org, security-officer@FreeBSD.org In-reply-to: Your message of "Thu, 14 Dec 2000 12:21:57 EST." <20001214122157.G1873@puck.firepipe.net> References: <20001214122157.G1873@puck.firepipe.net> <200012141225.eBECPn385434@freefall.freebsd.org> Date: Thu, 14 Dec 2000 10:26:20 -0700 From: Warner Losh Sender: imp@harmony.village.org Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org In message <20001214122157.G1873@puck.firepipe.net> Will Andrews writes: : On Thu, Dec 14, 2000 at 04:25:49AM -0800, Peter Pentchev wrote: : > Log: : > Forced commit: the previous checksum chase commit was because the source : > tarball changed. No functional differences, only some prototyp definitions : > were changed from C preprocessor macros to real C/C++ keywords. : > : > Requested by: kris (and SOP) : > Pointy hat: roam - I *did* remember that ftp.FreeBSD.org still carried : > the old distfile to diff against, but I remembered *after* : > the commit (and minutes later, was reminded of the same by : > several people) : : As a general rule, I see little point to noting the differences between : checksums.. most users will never know what your commit message about : this "problem" said, since most users don't read cvs commit messages. : Additionally, if the authors don't bother to document why they changed : the distribution without updating the version, then it's probably not : worth upgrading the port. Actually, I see a good reason for noting it. In the past there have been sites that have been compromized and the new checksum alerted people to the trojan. That's why we need to make sure that when checksums change, they are on purpose. Noting that fact in the commit log (but maybe not to the level of detail) is prudent and saves the SO from having to wonder if we've just introduced a trojan into our system. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message