From owner-freebsd-fs@FreeBSD.ORG Tue Jul 3 11:37:05 2012 Return-Path: Delivered-To: fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 016DC106564A; Tue, 3 Jul 2012 11:37:05 +0000 (UTC) (envelope-from markus.gebert@hostpoint.ch) Received: from mail.adm.hostpoint.ch (mail.adm.hostpoint.ch [IPv6:2a00:d70:0:a::e0]) by mx1.freebsd.org (Postfix) with ESMTP id 758188FC0C; Tue, 3 Jul 2012 11:37:04 +0000 (UTC) Received: from [77.109.131.203] (port=62592 helo=ch4buk-en0.office.hostpoint.internal) by mail.adm.hostpoint.ch with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69 (FreeBSD)) (envelope-from ) id 1Sm1Pj-000H8j-DX; Tue, 03 Jul 2012 13:37:03 +0200 Mime-Version: 1.0 (Apple Message framework v1278) From: Markus Gebert In-Reply-To: <201207021050.13974.jhb@freebsd.org> Date: Tue, 3 Jul 2012 13:37:02 +0200 Message-Id: References: <201206251443.41768.jhb@freebsd.org> <0EF22D00-1CDB-44DA-BF3C-3AC672072C05@hostpoint.ch> <201207021050.13974.jhb@freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.1278) Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: fs@freebsd.org Subject: Re: [PATCH] Simple ARC stats in top X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2012 11:37:05 -0000 On 02.07.2012, at 16:50, John Baldwin wrote: > On Monday, July 02, 2012 8:12:26 am Markus Gebert wrote: >> Hi John >>=20 >> On 27.06.2012, at 17:49, Markus Gebert wrote: >>=20 >>> On 27.06.2012, at 14:10, John Baldwin wrote: >>>=20 >>>> Hmmm, my patch is relative to a top that has -P backported and I = can't=20 >>>> reproduce this, the ARC lines moves around properly if 'P' is = toggled >>>> at runtime as well for me. Did you have any conflicts in your = patch >>>> that you had to resolve by hand? >>>=20 >>> No, I did not merge anything by hand. But what I did, and that = probably=20 > was the cause, is only buildworld with NO_CLEAN=3D1 to save time and = just=20 > rebuild top. Now that I've done a full buildworld, the probem seems to = be=20 > gone. I'll test more and step up, if it happens again, but consider = this=20 > solved for now. Sorry for the noise. >>=20 >> The problem is back. I don't know why I thought it was gone last = week, maybe=20 > I looked at the wrong terminal or something. >>=20 >> Anyway, I tried again today, and I can reproduce this not only on 8.3 = but=20 > also on 9.0. To rule out a problem with iTerm I also tried OS X = Terminal and=20 > Gnome Terminal on Ubuntu. The terminal does not seem to matter at all. >>=20 >> This sample output is from a patched top (run with -S -P) on a 9.0 = server=20 > connected to via ssh: >=20 > I found it. I wasn't updating y_arc for PCPU stats. Try this: Now it works perfectly. Thanks! Markus