From owner-svn-src-head@FreeBSD.ORG  Fri Dec 12 14:03:04 2008
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DDDC81065673;
	Fri, 12 Dec 2008 14:03:04 +0000 (UTC) (envelope-from kib@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id CD7588FC23;
	Fri, 12 Dec 2008 14:03:04 +0000 (UTC) (envelope-from kib@FreeBSD.org)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id mBCE34gD099395;
	Fri, 12 Dec 2008 14:03:04 GMT (envelope-from kib@svn.freebsd.org)
Received: (from kib@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id mBCE34qv099394;
	Fri, 12 Dec 2008 14:03:04 GMT (envelope-from kib@svn.freebsd.org)
Message-Id: <200812121403.mBCE34qv099394@svn.freebsd.org>
From: Konstantin Belousov <kib@FreeBSD.org>
Date: Fri, 12 Dec 2008 14:03:04 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r185987 - head/sys/kern
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Dec 2008 14:03:05 -0000

Author: kib
Date: Fri Dec 12 14:03:04 2008
New Revision: 185987
URL: http://svn.freebsd.org/changeset/base/185987

Log:
  Uio_yield() already does DROP_GIANT/PICKUP_GIANT, no need to repeat this
  around the call.
  
  Noted by:  bde

Modified:
  head/sys/kern/kern_sysctl.c

Modified: head/sys/kern/kern_sysctl.c
==============================================================================
--- head/sys/kern/kern_sysctl.c	Fri Dec 12 13:21:31 2008	(r185986)
+++ head/sys/kern/kern_sysctl.c	Fri Dec 12 14:03:04 2008	(r185987)
@@ -1423,9 +1423,7 @@ userland_sysctl(struct thread *td, int *
 		error = sysctl_root(0, name, namelen, &req);
 		if (error != EAGAIN)
 			break;
-		DROP_GIANT();
 		uio_yield();
-		PICKUP_GIANT();
 	}
 
 	if (req.lock == REQ_WIRED && req.validlen > 0)