From owner-freebsd-current@FreeBSD.ORG  Wed Jun  2 00:55:14 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2C01716A4D0; Wed,  2 Jun 2004 00:55:14 -0700 (PDT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 36CA043D45; Wed,  2 Jun 2004 00:55:13 -0700 (PDT)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i527sr0R014855;
	Wed, 2 Jun 2004 09:54:53 +0200 (CEST)
	(envelope-from phk@phk.freebsd.dk)
To: John Baldwin <jhb@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 01 Jun 2004 11:25:02 EDT."
             <200406011125.03166.jhb@FreeBSD.org> 
Date: Wed, 02 Jun 2004 09:54:53 +0200
Message-ID: <14854.1086162893@critter.freebsd.dk>
cc: current@FreeBSD.org
Subject: Re: boot2 patch, please test. 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Jun 2004 07:55:14 -0000

In message <200406011125.03166.jhb@FreeBSD.org>, John Baldwin writes:
>On Saturday 29 May 2004 05:21 pm, Poul-Henning Kamp wrote:
>> Some embedded boxes do not have the keyboard controller, and this
>> patch adds a timeout so they do not get stuck waiting for it to
>> become ready.
>>
>> Please test that this patch does not have any effect on normal
>> PC architecture machines.
>
>I'd prefer that you explicitly set %cx to a timeout value after the cli 
>instead of relying on its value being zero in the caller.

ENOMOREBYTES :-(

I guess the logical thing would be to inline it rather than have it be
a function, that saves the cx initializtion, the call and the return.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.