From owner-cvs-all Tue Apr 16 21:56:34 2002 Delivered-To: cvs-all@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id 7ABC237B42F; Tue, 16 Apr 2002 21:56:24 -0700 (PDT) Received: by flood.ping.uio.no (Postfix, from userid 2602) id B6F475309; Wed, 17 Apr 2002 06:56:21 +0200 (CEST) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: John Baldwin Cc: Poul-Henning Kamp , Steve Kargl , cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, "Greg 'groggy' Lehey" , Jeroen Ruigrok/asmodai , obrien@FreeBSD.ORG Subject: Re: cvs commit: src/sbin/savecore savecore.c References: From: Dag-Erling Smorgrav Date: 17 Apr 2002 06:56:20 +0200 In-Reply-To: Message-ID: Lines: 17 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG John Baldwin writes: > On 16-Apr-2002 Poul-Henning Kamp wrote: > > I wanted to avoid having to open the disk device in RW mode, so the > > best way to find out if we had already saved a dump was to make > > a hash of the header and look for that. > Hmm, I really don't like that. I find the current scheme of vmcore.XX and > kernel.XX to be rather intuitive. For one thing, it makes it very easy to see > which dump is the most recent. Why can't you save the hash of the header in > the core file or something but still keep the filenames usable. Surely we > don't have to give up useful filenames for this. The point is moot anyway, because savecore(8) now opens the device read-write. Just revert to the old naming scheme. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message