From owner-cvs-src@FreeBSD.ORG Fri Dec 7 16:58:49 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0C82116A41A for ; Fri, 7 Dec 2007 16:58:49 +0000 (UTC) (envelope-from cokane@freebsd.org) Received: from QMTA06.westchester.pa.mail.comcast.net (qmta06.westchester.pa.mail.comcast.net [76.96.62.56]) by mx1.freebsd.org (Postfix) with ESMTP id 995C413C465 for ; Fri, 7 Dec 2007 16:58:48 +0000 (UTC) (envelope-from cokane@freebsd.org) Received: from OMTA05.westchester.pa.mail.comcast.net ([76.96.62.43]) by QMTA06.westchester.pa.mail.comcast.net with comcast id MsFW1Y00P0vyq2s0504N00; Fri, 07 Dec 2007 16:47:48 +0000 Received: from discordia ([24.60.136.97]) by OMTA05.westchester.pa.mail.comcast.net with comcast id Msnn1Y00Q26FYqY0300000; Fri, 07 Dec 2007 16:47:48 +0000 X-Authority-Analysis: v=1.0 c=1 a=05kuoAx_uc8A:10 a=O1_F7ShucbV9jOmx80MA:9 a=FmvKkpzimMYS3JElp-4A:7 a=mGTBKkevVel0t0SttixQub7myhUA:4 a=zUBsD6tbDSsA:10 Received: by discordia (Postfix, from userid 103) id 047411634F7; Fri, 7 Dec 2007 11:47:48 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.1.8-gr1 (2007-02-13) on discordia X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.8-gr1 Received: from [172.20.1.3] (erwin.int.cokane.org [172.20.1.3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by discordia (Postfix) with ESMTP id 93B3A1634F6; Fri, 7 Dec 2007 11:47:34 -0500 (EST) Message-ID: <47597900.1070006@FreeBSD.org> Date: Fri, 07 Dec 2007 11:46:56 -0500 From: Coleman Kane Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.9 (X11/20071116) MIME-Version: 1.0 To: John Baldwin References: <200712062311.lB6NBSBD081134@repoman.freebsd.org> In-Reply-To: <200712062311.lB6NBSBD081134@repoman.freebsd.org> X-Enigmail-Version: 0.96a Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_module.c src/sys/compat/freebsd32 freebsd32.h freebsd32_misc.c syscalls.master X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: cokane@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Dec 2007 16:58:49 -0000 John Baldwin wrote: > jhb 2007-12-06 23:11:27 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_module.c > sys/compat/freebsd32 freebsd32.h freebsd32_misc.c > syscalls.master > Log: > Move several data structure definitions out of freebsd32_misc.c and into > freebsd32.h instead. > > MFC after: 1 week > > Revision Changes Path > 1.7 +56 -0 src/sys/compat/freebsd32/freebsd32.h > 1.69 +36 -83 src/sys/compat/freebsd32/freebsd32_misc.c > 1.92 +1 -0 src/sys/compat/freebsd32/syscalls.master > 1.53 +1 -0 src/sys/kern/kern_module.c > This commit now causes the following error when building the kernel on my system: cc -c -O2 -frename-registers -pipe -fno-strict-aliasing -march=athlon64 -std=c99 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-omit-frame-pointer -mcmodel=kernel -mno-red-zone -mfpmath=387 -mno-sse -mno-sse2 -mno-mmx -mno-3dnow -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -Werror /usr/src/sys/compat/freebsd32/freebsd32_misc.c /usr/src/sys/compat/freebsd32/freebsd32_misc.c: In function 'copy_statfs': /usr/src/sys/compat/freebsd32/freebsd32_misc.c:153: error: void value not ignored as it ought to be *** Error code 1 Looking in src/sys/sys, the offending function call, statfs_scale_blocks is defined as void return type in mount.h but a return value is expected at this point in freebsd32_misc.c. sys/sys/mount.h:void statfs_scale_blocks(struct statfs *sf, long max_size); -- Coleman Kane