From owner-cvs-src@FreeBSD.ORG Sat Oct 8 05:31:45 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1AED016A41F; Sat, 8 Oct 2005 05:31:45 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9E97743D45; Sat, 8 Oct 2005 05:31:44 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id j985TS0B063248; Fri, 7 Oct 2005 23:29:28 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 07 Oct 2005 23:30:25 -0600 (MDT) Message-Id: <20051007.233025.00238018.imp@bsdimp.com> To: yar@comp.chem.msu.su From: "M. Warner Losh" In-Reply-To: <20051008044623.GA2392@comp.chem.msu.su> References: <200510051009.j95A9HpC024040@repoman.freebsd.org> <20051005230120.B51543@delplex.bde.org> <20051008044623.GA2392@comp.chem.msu.su> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Fri, 07 Oct 2005 23:29:29 -0600 (MDT) Cc: cvs-src@FreeBSD.org, glebius@FreeBSD.org, cvs-all@FreeBSD.org, bde@zeta.org.au, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/conf options src/sys/dev/em if_em.c src/sys/dev/firewire if_fwe.c if_fwip.c src/sys/dev/fxp if_fxp.c src/sys/dev/ixgb if_ixgb.c src/sys/dev/nge if_nge.c src/sys/dev/re if_re.c src/sys/dev/vge if_vge.c src/sys/kern kern_clock.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Oct 2005 05:31:45 -0000 In message: <20051008044623.GA2392@comp.chem.msu.su> Yar Tikhiy writes: : On Wed, Oct 05, 2005 at 11:01:47PM +1000, Bruce Evans wrote: : > On Wed, 5 Oct 2005, Gleb Smirnoff wrote: : > : > >glebius 2005-10-05 10:09:17 UTC : > > : > > FreeBSD src repository : > > : > > Modified files: : > > sys/conf options : > > sys/dev/em if_em.c : > > sys/dev/firewire if_fwe.c if_fwip.c : > > sys/dev/fxp if_fxp.c : > > sys/dev/ixgb if_ixgb.c : > > sys/dev/nge if_nge.c : > > sys/dev/re if_re.c : > > sys/dev/vge if_vge.c : > > sys/kern kern_clock.c kern_poll.c : > > sys/net netisr.c : > > sys/pci if_dc.c if_rl.c if_sf.c if_sis.c if_ste.c : > > if_vr.c if_xl.c : > > Log: : > > - Don't pollute opt_global.h with DEVICE_POLLING and introduce : > > opt_device_polling.h : > > - Include opt_device_polling.h into appropriate files. : > > - Embrace with HAVE_KERNEL_OPTION_HEADERS the include in the files that : > > can be compiled as loadable modules. : > > : > > Reviewed by: bde : > : > Requested too. Thanks. : : According to this scheme, is every opt_*.h inclusion to be wrapped : in "ifdef HAVE_KERNEL_OPTION_HEADERS" eventually? I sure hope not... this seems like a step backwards... Warner