From owner-cvs-sys  Fri Apr 17 22:08:20 1998
Return-Path: <owner-cvs-sys>
Received: (from daemon@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id WAA01427
          for cvs-sys-outgoing; Fri, 17 Apr 1998 22:08:20 -0700 (PDT)
          (envelope-from owner-cvs-sys)
Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA01416;
          Sat, 18 Apr 1998 05:08:12 GMT
          (envelope-from julian@whistle.com)
Received: (from daemon@localhost)
	by alpo.whistle.com (8.8.5/8.8.5) id WAA01918;
	Fri, 17 Apr 1998 22:05:54 -0700 (PDT)
Received: from current1.whistle.com(207.76.205.22)
 via SMTP by alpo.whistle.com, id smtpd001916; Sat Apr 18 05:05:47 1998
Message-ID: <3538336F.41C67EA6@whistle.com>
Date: Fri, 17 Apr 1998 22:00:31 -0700
From: Julian Elischer <julian@whistle.com>
Organization: Whistle Communications
X-Mailer: Mozilla 3.0Gold (X11; I; FreeBSD 2.2.5-RELEASE i386)
MIME-Version: 1.0
To: Peter Wemm <peter@netplex.com.au>
CC: "Dag-Erling C. Smxf8rgrav" <des@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG,
        cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/dev/dpt dpt_control.c src/sys/gnu/ext2fs...
References: <199804180411.MAA16043@spinner.netplex.com.au>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-sys@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

Peter Wemm wrote:
> 
> "Dag-Erling C. Sm\xf8rgrav" wrote:
> > des         1998/04/17 15:37:20 PDT
> >
> >   Modified files:
> >     sys/dev/dpt          dpt_control.c
> >     sys/gnu/ext2fs       COPYRIGHT.INFO ext2_alloc.c ext2_vnops.c
> [..]
> >     sys/ufs/ufs          ufs_vnops.c
> >   Log:
> >   Seventy-odd "its" / "it's" typos in comments fixed as per kern/6108.
> 
> What the hell???  I don't call this "fixing typos", as far as I can tell,
> most of these changes have broken the correct usage.
> 
> eg:  here, we are talking about the device's softc:
> +++ dpt_control.c       1998/03/23 10:49:01
> @@ -175,7 +175,7 @@
> 
>  /**
>   * Given a minor device number,
> - * return the pointer to it's softc structure
> + * return the pointer to its softc structure


sorry to contradict you Peter but this is the trick..

"its" is a single word, the same as:
"his" and "her"

as in:

his cat, her cat, its cat


the other version,  e.g.
"Joh's crow" or  "John's VM code",
shouldn't be confused with this..

why schools never explain it in this way I'll never understand.
it took me years till someone explained this to me so clearly..

Until then I'd assumed..
"Sue's cakes", "John's cat", "it's softc"

but that's wrong.
"it's" is soley for the contraction "it is".

julian

 

>   */
> 
>  static INLINE dpt_softc_t *
> 
> eg: here we are talking about the card's EEROM.
> +++ if_ed.c     1998/03/23 11:05:46
> @@ -676,7 +676,7 @@
>  #endif
>         DELAY(100);
>         outb(sc->asic_addr + ED_WD_MSR, inb(sc->asic_addr + ED_WD_MSR) & ~ED_WD_
> MSR_RST);
> -       /* wait in the case this card is reading it's EEROM */
> +       /* wait in the case this card is reading its EEROM */
>         DELAY(5000);
> 
>         sc->vendor = ED_VENDOR_WD_SMC;
> 
> And so on...
> 
> Just because a PR is submitted, it doesn't mean it's right.  If they were
> always right, there would be an automatic patch application process on PR
> submission.
> 
> -Peter