From owner-svn-src-head@freebsd.org Fri Jan 25 00:15:59 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 19E8014C4312 for ; Fri, 25 Jan 2019 00:15:59 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1.eu.mailhop.org (outbound1.eu.mailhop.org [52.28.251.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48F528E95E for ; Fri, 25 Jan 2019 00:15:58 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1548374384; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=IhU5Z7fq9XDu4QVLiFZbHY36lbfZuuAZTeS6JR4fpl2YwRQm8w1vwt/gmeVE6OaskIGxLPWuM9LvP IRKiBpFHDOvJht6kA7+k0XSss1OqR/1nUK2ZgTa8/RmSAa4kczLrFaNAzNjYzAlmwa1cEOjFUMhdxf esbmvF8//ItEqG25qzpH1IDvJbPmOzIHmwVoQ6gDLkEMlyeYAO0pQORIIPR2YpBWj5y68KWWhF8ePx xvF9y2tCE2LoNwvhdcF4iTI70TrTZusIvfsGT2tEd978D5I0iFZnOVj0GWbKjFUK5GOyYITmpOuyGj F4qWwmyKlUu1zBILRu+YEMuyHBJXycA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=VBFwOtucCkSCwRaGe8DxOZwVSejGaKoaMeVpX2Dq3m4=; b=EfVDbKcC0ihqeLUvT8+/jgJ0A+Ns5VoHbHqpEnLU11AAN7dnPQH+CAkCGnfyLk9EUE5RTjiXCYoI4 DTskXGLx+7Vd0rormBX2KrySC/nx/hrrqlX+pLacG80m5V8EUzcx6dl7IQmQJN57KTuErBW3m73ca4 mUYLiDXa6oCHh+yxiuEGNwKX1IyEMrUtSslIgwc44i91V2gARkm93dEVE9bg9qyT5GV01B2plKf7br vxe9KDdu4tyFvuJvSt5oSncbi5RPc+TWMTyn23hFX54WAEdwzSgnC7f7V3lbaRtbkupx5PCTQvv9tQ 08wDLw/jNncLqB2+vDkmaXJ1sn9ezPw== ARC-Authentication-Results: i=1; outbound3.eu.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=VBFwOtucCkSCwRaGe8DxOZwVSejGaKoaMeVpX2Dq3m4=; b=C3MhRy057dkba0dUJa8gRUR5ubjzmte8k0N3OnRuvIVmQFQyQjII+JStmpqZfs05M6ff2u91c5IRm qoWFolo8oPAcZs1otwKOTwARUf+CJy4uQ3Fufn2e0IGs7UWPq5yeEuKMnvyZfu1Tvb4CkkQAj+CLGk u+jNDnZC/UWGNifzuQ7l+Bhz73+VFcg0/WYpsEkx8enI2pdi5YLZb/zDpLhbn9l7D36tpoN+l6/o3j 2PCGJqD+f8fZHSKet6c/lbBcMrAqu7no2akvgVVG5aTk688BagvREMaMHRvyXPI+Tj1kmskALhFfXd huMa5wPZx8jsGrGKEWbuuLmIlGNvYxA== X-MHO-RoutePath: aGlwcGll X-MHO-User: 1cced4f4-2034-11e9-8a28-a1efd8da9a94 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.eu.mailhop.org (Halon) with ESMTPSA id 1cced4f4-2034-11e9-8a28-a1efd8da9a94; Thu, 24 Jan 2019 23:59:41 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x0ONxeHX002783; Thu, 24 Jan 2019 16:59:40 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <5bf59c74ab2bfaf831811df273ae1adde1599acc.camel@freebsd.org> Subject: Re: svn commit: r343416 - head/bin/sh From: Ian Lepore To: rgrimes@freebsd.org, Edward Tomasz Napierala Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Thu, 24 Jan 2019 16:59:40 -0700 In-Reply-To: <201901242355.x0ONt4Xl085460@pdx.rh.CN85.dnsmgr.net> References: <201901242355.x0ONt4Xl085460@pdx.rh.CN85.dnsmgr.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 48F528E95E X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-7.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-1.00)[-0.995,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 00:15:59 -0000 On Thu, 2019-01-24 at 15:55 -0800, Rodney W. Grimes wrote: > > Author: trasz > > Date: Thu Jan 24 23:34:51 2019 > > New Revision: 343416 > > URL: https://svnweb.freebsd.org/changeset/base/343416 > > > > Log: > > Install .shrc for root, and set PS1 for the toor account. > > And a dozen other aliases :-( > Please do not contaiminate the prestine environment with > personal preferences. In the start of the project we > did a great deal of work to remove and eliminate these > types of things, only the few csh aliases where retained. > > This is really the domain of a systems administrator to > decide and making work for them to clean this out is > not going to make them happy. > > The commands in an ENV file well be executed by > every single shell that is started, not just an > interactive shell, unless I am mis reading the > man page: > If the environment variable ENV is set on > entry to a shell, or is set in the .profile of a login shell, the > shell > then subjects its value to parameter expansion and arithmetic > expansion > and reads commands from the named file. > I agree with all of tat. If the local sysadmin wants to make /bin/sh friendly as an interactive shell, maybe we could provide some .sample files to make that easy, but we SHOULD NOT put all this junk in by default. -- Ian > > Reviewed by: jilles > > MFC after: 2 weeks > > Sponsored by: DARPA, AFRL > > Differential Revision: https://reviews.freebsd.org/D18872 > > > > Added: > > head/bin/sh/dot.shrc > > - copied unchanged from r343399, head/share/skel/dot.shrc > > Modified: > > head/bin/sh/Makefile > > head/bin/sh/dot.profile > > > > Modified: head/bin/sh/Makefile > > =================================================================== > > =========== > > --- head/bin/sh/Makefile Thu Jan 24 22:34:30 2019 (r343415) > > +++ head/bin/sh/Makefile Thu Jan 24 23:34:51 2019 (r343416) > > @@ -3,9 +3,12 @@ > > > > .include > > > > -CONFS= dot.profile profile > > -CONFSDIR_dot.profile= /root > > -CONFSNAME_dot.profile= .profile > > +CONFGROUPS= ETC ROOT > > +ETC= profile > > +ROOT= dot.shrc dot.profile > > +ROOTDIR= /root > > +ROOTNAME_dot.shrc= .shrc > > +ROOTNAME_dot.profile= .profile > > PACKAGE=runtime > > PROG= sh > > INSTALLFLAGS= -S > > > > Modified: head/bin/sh/dot.profile > > =================================================================== > > =========== > > --- head/bin/sh/dot.profile Thu Jan 24 22:34:30 2019 (r343415) > > +++ head/bin/sh/dot.profile Thu Jan 24 23:34:51 2019 (r343416) > > @@ -9,6 +9,9 @@ export TERM > > PAGER=less > > export PAGER > > > > +# set ENV to a file invoked each time sh is started for > > interactive use. > > +ENV=$HOME/.shrc; export ENV > > + > > # Query terminal size; useful for serial lines. > > if [ -x /usr/bin/resizewin ] ; then /usr/bin/resizewin -z ; fi > > > > > > Copied: head/bin/sh/dot.shrc (from r343399, > > head/share/skel/dot.shrc) > > =================================================================== > > =========== > > --- /dev/null 00:00:00 1970 (empty, because file is > > newly added) > > +++ head/bin/sh/dot.shrc Thu Jan 24 23:34:51 2019 (r343416, > > copy of r343399, head/share/skel/dot.shrc) > > @@ -0,0 +1,39 @@ > > +# $FreeBSD$ > > +# > > +# .shrc - bourne shell startup file > > +# > > +# This file will be used if the shell is invoked for interactive > > use and > > +# the environment variable ENV is set to this file. > > +# > > +# see also sh(1), environ(7). > > +# > > + > > + > > +# file permissions: rwxr-xr-x > > +# > > +# umask 022 > > + > > +# Uncomment this to enable the builtin vi(1) command line editor > > in sh(1), > > +# e.g. ESC to go into visual mode. > > +# set -o vi > > + > > + > > +# some useful aliases > > +alias h='fc -l' > > +alias j=jobs > > +alias m="$PAGER" > > +alias ll='ls -laFo' > > +alias l='ls -l' > > +alias g='egrep -i' > > + > > +# # be paranoid > > +# alias cp='cp -ip' > > +# alias mv='mv -i' > > +# alias rm='rm -i' > > + > > + > > +# set prompt: ``username@hostname:directory $ '' > > +PS1="\u@\h:\w \\$ " > > + > > +# search path for cd(1) > > +# CDPATH=:$HOME > > > > > >