From owner-freebsd-bugs@FreeBSD.ORG Tue Dec 28 16:20:10 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CABCF1065672 for ; Tue, 28 Dec 2010 16:20:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 9B0EF8FC13 for ; Tue, 28 Dec 2010 16:20:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oBSGKAxi024485 for ; Tue, 28 Dec 2010 16:20:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oBSGKAGR024482; Tue, 28 Dec 2010 16:20:10 GMT (envelope-from gnats) Date: Tue, 28 Dec 2010 16:20:10 GMT Message-Id: <201012281620.oBSGKAGR024482@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: "Pedro F. Giffuni" Cc: Subject: Re: bin/153261: sed: fix for a race condition (from illumos) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Pedro F. Giffuni" List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Dec 2010 16:20:10 -0000 The following reply was made to PR bin/153261; it has been noted by GNATS. From: "Pedro F. Giffuni" To: bug-followup@FreeBSD.org, Jilles Tjoelker Cc: Subject: Re: bin/153261: sed: fix for a race condition (from illumos) Date: Tue, 28 Dec 2010 08:19:42 -0800 (PST) --0-1632005195-1293553182=:99003 Content-Type: text/plain; charset=us-ascii I can confirm there was a problem with msdosfs. The attached patch fixes it. --0-1632005195-1293553182=:99003 Content-Type: text/plain; name="patch-sed1.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch-sed1.txt" LS0tIHNlZC9tYWluLmMub3JpZwkyMDEwLTEyLTE4IDE4OjM3OjUwLjAwMDAw MDAwMCArMDAwMAorKysgc2VkL21haW4uYwkyMDEwLTEyLTI4IDExOjAxOjQz LjAwMDAwMDAwMCArMDAwMApAQCAtMzM4LDE4ICszMzgsMzUgQEAKIAkJaWYg KGluZmlsZSAhPSBOVUxMKSB7CiAJCQlmY2xvc2UoaW5maWxlKTsKIAkJCWlm ICgqb2xkZm5hbWUgIT0gJ1wwJykgewotCQkJCWlmIChyZW5hbWUoZm5hbWUs IG9sZGZuYW1lKSAhPSAwKSB7Ci0JCQkJCXdhcm4oInJlbmFtZSgpIik7Ci0J CQkJCXVubGluayh0bXBmbmFtZSk7Ci0JCQkJCWV4aXQoMSk7CisJCQkJLyog aWYgdGhlcmUgd2FzIGEgYmFja3VwIGZpbGUsIHJlbW92ZSBpdCAqLworCQkJ CXVubGluayhvbGRmbmFtZSk7CisJCQkJaWYgKGxpbmsoZm5hbWUsIG9sZGZu YW1lKSAhPSAwKSB7CisJCQkJCWlmIChlcnJubyA9PSBFT1BOT1RTVVBQKSB7 CisJCQkJCQlpZiAocmVuYW1lKGZuYW1lLCBvbGRmbmFtZSkgIT0gMCkKKwkJ CQkJCQl3YXJuKCJyZW5hbWUoKSIpOworCQkJCQl9CisJCQkJCWVsc2Ugewor CQkJCQkJd2FybigibGluaygpIik7CisJCQkJCQl1bmxpbmsodG1wZm5hbWUp OworCQkJCQkJZXhpdCgxKTsKKwkJCQkJfQogCQkJCX0KIAkJCQkqb2xkZm5h bWUgPSAnXDAnOwogCQkJfQogCQkJaWYgKCp0bXBmbmFtZSAhPSAnXDAnKSB7 CiAJCQkJaWYgKG91dGZpbGUgIT0gTlVMTCAmJiBvdXRmaWxlICE9IHN0ZG91 dCkKLQkJCQkJZmNsb3NlKG91dGZpbGUpOworCQkJCQlpZiAoZmNsb3NlKG91 dGZpbGUpICE9IDApIHsKKwkJCQkJCXdhcm4oImZjbG9zZSgpIik7CisJCQkJ CQl1bmxpbmsodG1wZm5hbWUpOworCQkJCQkJZXhpdCgxKTsKKwkJCQkJfQog CQkJCW91dGZpbGUgPSBOVUxMOwotCQkJCXJlbmFtZSh0bXBmbmFtZSwgZm5h bWUpOworCQkJCWlmIChyZW5hbWUodG1wZm5hbWUsIGZuYW1lKSAhPSAwKSB7 CisJCQkJCS8qIHRoaXMgc2hvdWxkIG5vdCBoYXBwZW4gcmVhbGx5ISAqLwor CQkJCQl3YXJuKCJyZW5hbWUoKSIpOworCQkJCQl1bmxpbmsodG1wZm5hbWUp OworCQkJCQlleGl0KDEpOworCQkJCX0KIAkJCQkqdG1wZm5hbWUgPSAnXDAn OwogCQkJfQogCQkJb3V0Zm5hbWUgPSBOVUxMOwo= --0-1632005195-1293553182=:99003--