From owner-freebsd-current@FreeBSD.ORG Fri May 15 09:31:31 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AD27410656C3 for ; Fri, 15 May 2009 09:31:31 +0000 (UTC) (envelope-from serenity@exscape.org) Received: from ch-smtp01.sth.basefarm.net (ch-smtp01.sth.basefarm.net [80.76.149.212]) by mx1.freebsd.org (Postfix) with ESMTP id 66B488FC1B for ; Fri, 15 May 2009 09:31:31 +0000 (UTC) (envelope-from serenity@exscape.org) Received: from c83-253-252-234.bredband.comhem.se ([83.253.252.234]:51246 helo=mx.exscape.org) by ch-smtp01.sth.basefarm.net with esmtp (Exim 4.69) (envelope-from ) id 1M4tkJ-0007j4-3Y; Fri, 15 May 2009 11:30:29 +0200 Received: from [192.168.1.5] (macbookpro [192.168.1.5]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx.exscape.org (Postfix) with ESMTPSA id DCDB16E0EC; Fri, 15 May 2009 11:30:22 +0200 (CEST) Message-Id: From: Thomas Backman To: James R. Van Artsdalen In-Reply-To: <4A0C9B0C.4050403@jrv.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Date: Fri, 15 May 2009 11:30:22 +0200 References: <08D1E6DF-89D3-4887-9234-C3DB9164D794@exscape.org> <20090514133017.362075dhcdy7o2bs@webmail.leidinger.net> <7CD27FF0-CBFA-48B7-9E18-763D8C3ED9B8@exscape.org> <4A0C9B0C.4050403@jrv.org> X-Mailer: Apple Mail (2.935.3) X-Originating-IP: 83.253.252.234 X-Scan-Result: No virus found in message 1M4tkJ-0007j4-3Y. X-Scan-Signature: ch-smtp01.sth.basefarm.net 1M4tkJ-0007j4-3Y 5bc2db6e5aeaef062bae5ea38f82ce77 Cc: freebsd-current@freebsd.org Subject: Re: zfs send -R segfault, anyone else? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2009 09:31:32 -0000 On May 15, 2009, at 12:28 AM, James R. Van Artsdalen wrote: > Thomas Backman wrote: >> [root@chaos ~]# zfs send -R -I $OLD tank@$NOW > diff-snap >> [root@chaos ~]# cat diff-snap | zfs recv -Fvd slave >> Segmentation fault: 11 (core dumped) >> >> Same kinda backtrace, but what's up with strcmp()? >> I suppose the issue stems from libzfs, and is not within libc: > > Different problem The SIGSEGV is happening in strcmp because it is > called with strcmp(0,0) > and tries to dereference address -4 (probably another bug itself). > > This hack gets around the issue but someone familiar with this needs > to > decide the correct action. > > The first change is actually unrelated (a sorry attempt at fixing the > previous zfs send bug). > > The last change may be unnecessary as that case may never happen > unless > the pool can be renamed? > > [... patch ...] Thanks! This list is pretty impressive. :) I can't validate how correct the fix is, considering my lacking knowledge in C (I know the basics, but kernel/related programming? no way!), but I CAN say that it appears to work just fine! Regards, Thomas