Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 24 Jun 2010 07:57:23 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Juli Mallett <jmallett@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, xcllnt@mac.com, nwhitehorn@freebsd.org, svn-src-head@freebsd.org, "M. Warner Losh" <imp@bsdimp.com>
Subject:   Re: svn commit: r209490 - head/sys/kern
Message-ID:  <201006240757.23510.jhb@freebsd.org>
In-Reply-To: <AANLkTinYyrwpUpdfO8CUv7VuEROg3GZqmpXdHWm5nHgK@mail.gmail.com>
References:  <201006232326.o5NNQEtK011793@svn.freebsd.org> <20100623.202647.867924114552092597.imp@bsdimp.com> <AANLkTinYyrwpUpdfO8CUv7VuEROg3GZqmpXdHWm5nHgK@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 23 June 2010 10:56:46 pm Juli Mallett wrote:
> On Wed, Jun 23, 2010 at 19:26, M. Warner Losh <imp@bsdimp.com> wrote:
> 
> > : > #    define HZ 1000
> > : > #  else
> > : > #    define HZ 100
> >
> > Shouldn't this be defined in some file in ARCH/include instead?

Yes, machine/param.h should work just fine.  We could leave a default of 1000 
via the current #ifndef and just move the non-default settings into MD 
headers.

> Didn't it used to be?  I think the problem with doing that is that
> then someone inevitably writes code that uses HZ instead of the
> (tunable) hz.  Of course, you can hide it behind an obscure #ifdef and
> even give it an intimidating name.

No, it's been in subr_param.c since at least 4.4BSD.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006240757.23510.jhb>