From owner-svn-src-head@freebsd.org  Tue Apr 19 14:41:42 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3ACABB144AD
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Tue, 19 Apr 2016 14:41:42 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from erouter6.ore.mailhop.org (erouter6.ore.mailhop.org
 [54.187.213.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 03CC51F38
 for <svn-src-head@freebsd.org>; Tue, 19 Apr 2016 14:41:41 +0000 (UTC)
 (envelope-from ian@freebsd.org)
X-MHO-User: cc125860-063c-11e6-b8f9-33a5b3560672
X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information
X-Originating-IP: 73.34.117.227
X-Mail-Handler: DuoCircle Outbound SMTP
Received: from ilsoft.org (unknown [73.34.117.227])
 by outbound3.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA;
 Tue, 19 Apr 2016 14:41:27 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.15.2/8.14.9) with ESMTP id u3JEfdme035810;
 Tue, 19 Apr 2016 08:41:39 -0600 (MDT) (envelope-from ian@freebsd.org)
Message-ID: <1461076899.1232.23.camel@freebsd.org>
Subject: Re: svn commit: r298268 - head/sys/dev/spibus
From: Ian Lepore <ian@freebsd.org>
To: Ruslan Bukin <br@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Date: Tue, 19 Apr 2016 08:41:39 -0600
In-Reply-To: <201604191418.u3JEICrY023254@repo.freebsd.org>
References: <201604191418.u3JEICrY023254@repo.freebsd.org>
Content-Type: text/plain; charset="us-ascii"
X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Apr 2016 14:41:42 -0000

On Tue, 2016-04-19 at 14:18 +0000, Ruslan Bukin wrote:
> Author: br
> Date: Tue Apr 19 14:18:12 2016
> New Revision: 298268
> URL: https://svnweb.freebsd.org/changeset/base/298268
> 
> Log:
>   Add optional chip_select/deselect methods. This is required
>   when we want to keep CS asserted for multiple transfers.
> 

This is missing a now-required mechanism to arbitrate ownership of the
bus.  If a leaf driver can take over the bus for longer than a single
transfer, then it needs the same kind of logic as the iicbus uses
(well, conceptually the same, it doesn't need the same horrible
implementation).

I also don't see any default implementation of the new methods, or a
commit that adds the new functionality to all existing SPI controller
drivers.

-- Ian