From owner-freebsd-current@FreeBSD.ORG Tue Apr 26 09:43:58 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F070A16A4CE for ; Tue, 26 Apr 2005 09:43:57 +0000 (GMT) Received: from 62-15-211-171.inversas.jazztel.es (62-15-211-171.inversas.jazztel.es [62.15.211.171]) by mx1.FreeBSD.org (Postfix) with ESMTP id 24A9643D5C for ; Tue, 26 Apr 2005 09:43:57 +0000 (GMT) (envelope-from josemi@freebsd.jazztel.es) Received: from redesjm.local (orion.redesjm.local [192.168.254.16]) j3Q9hthR000825 for ; Tue, 26 Apr 2005 11:43:55 +0200 (CEST) (envelope-from josemi@redesjm.local) Received: from localhost (localhost [[UNIX: localhost]]) by redesjm.local (8.13.3/8.13.3/Submit) id j3Q9ht4Q014686 for freebsd-current@freebsd.org; Tue, 26 Apr 2005 11:43:55 +0200 (CEST) (envelope-from josemi@redesjm.local) From: Jose M Rodriguez To: freebsd-current@freebsd.org Date: Tue, 26 Apr 2005 11:43:54 +0200 User-Agent: KMail/1.8 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200504261143.55195.josemi@redesjm.local> X-AntiVirus: checked by AntiVir Milter (version: 1.1.0-3; AVE: 6.30.0.7; VDF: 6.30.0.116; host: antares.redesjm.local) Subject: rigth crc32 implementation X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2005 09:43:58 -0000 Hi, Working on usb_adslsubr{.c,.h} About how to implement crc32 My first think was use the libkern based one, but I found: sys/linkern/crc32.c - the code may not be endian safe. - the code lacks support for processing chuncks. Add the functions for the second target may be easy (please, sugest names), but I found a latest problem: At last geom uses this to sign data structures. If the code is made endian safe, this will break geom. At the moment, I'll work this into usb_adslsubr{.c,.h}, but I'll glad to know if those targets will be wellcome. -- josemi