Date: Tue, 28 Jul 2020 12:50:35 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 248323] databases/sqlite3: Line editing library options broken Message-ID: <bug-248323-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D248323 Bug ID: 248323 Summary: databases/sqlite3: Line editing library options broken Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: madpilot@FreeBSD.org CC: pavelivolkov@gmail.com, sunpoet@FreeBSD.org Blocks: 239228 CC: pavelivolkov@gmail.com Flags: maintainer-feedback?(pavelivolkov@gmail.com) Attachment #216835 maintainer-approval?(pavelivolkov@gmail.com) Flags: Flags: maintainer-feedback?(pavelivolkov@gmail.com) Created attachment 216835 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D216835&action= =3Dedit Fix for sqlite3 readline/libedit options Hi, I just noticed that after r542047 has been committed the options to have a = line editing library linked with sqlite3 are all broken. At present the port defines option names READLINES, READLINEP and EDITLINE,= but then uses option helpers for option name READLINE and LIBEDIT. This makes it impossible to have the port link with any of these libraries. This has also been noticed by sunpoet in a message to svn-ports-all. r542047 also removed all these options descriptions, which I'm putting back with slightly changed text. While here I also made the other descriptions all start with upper case letters, as is usually done. I'm attaching a patch partly reverting r542047, putting back READLINES and READLINEP option helpers, and also fixing the EDITLINE/LIBEDIT incongruity.= I'm leaving the change of default to libedit and moving from OPTIONS_GROUP to OPTIONS_RADIO. BTW the change to OPTIONS_RADIO also fixes bug 239228, which I'm referencing from this bug. I'd like to commit this soon to fix the immediate issue and add back the op= tion to have a line editing library linked in sqlite3. If further changes are planned to the port those can be discussed later. Referenced Bugs: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D239228 [Bug 239228] databases/sqlite3: sqlite3-3.28.0 config interface should rest= rict READLINES vs READLINEP options --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-248323-7788>