From owner-svn-src-head@freebsd.org Wed Jul 18 14:49:53 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C77CF104CFF3; Wed, 18 Jul 2018 14:49:53 +0000 (UTC) (envelope-from ben@bwidawsk.net) Received: from mail.bwidawsk.net (zangief.bwidawsk.net [107.170.211.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "bwidawsk.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 601A47D5DE; Wed, 18 Jul 2018 14:49:53 +0000 (UTC) (envelope-from ben@bwidawsk.net) Received: by mail.bwidawsk.net (Postfix, from userid 5001) id B9364123337; Wed, 18 Jul 2018 07:49:45 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on zangief.bwidawsk.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-1.0 required=4.1 tests=ALL_TRUSTED=-1 shortcircuit=no autolearn=no autolearn_force=no version=3.4.1 Received: from mail.bwidawsk.net (c-73-25-164-31.hsd1.or.comcast.net [73.25.164.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail.bwidawsk.net (Postfix) with ESMTPSA id 66280122549; Wed, 18 Jul 2018 07:49:39 -0700 (PDT) Date: Wed, 18 Jul 2018 07:49:38 -0700 From: Ben Widawsky To: Warner Losh Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336431 - head/stand/efi/libefi Message-ID: <20180718144938.t6tgplozi7mbl6p4@mail.bwidawsk.net> Mail-Followup-To: Warner Losh , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201807172145.w6HLjEhl004493@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201807172145.w6HLjEhl004493@repo.freebsd.org> User-Agent: NeoMutt/20180716 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jul 2018 14:49:54 -0000 On 18-07-17 21:45:14, Warner Losh wrote: > Author: imp > Date: Tue Jul 17 21:45:14 2018 > New Revision: 336431 > URL: https://svnweb.freebsd.org/changeset/base/336431 > > Log: > Remove bogus attempt to simulate scrolling. It's not needed and messes > up serial output. Setting the cursor position after every character is > inefficient, and causes all lines to be over-printed in the serial > console for the boot loader. Allow the terminal to do the emulation. > > This isn't completely perfect when the size of the terminal attached > to the serial port isn't the same as 80x25 to match the viedoe console > (or whatever the video console is). While imperfect still, these > changes make it much better. > > This makes the serial port useful with UEFI. Unfortunately, I still can't use EFI and serial console together reliably, but when I have used both, this issue was incredibly annoying. Thanks for fixing. > > Differential Revision: https://reviews.freebsd.org/D16309 > > Modified: > head/stand/efi/libefi/efi_console.c > > Modified: head/stand/efi/libefi/efi_console.c > ============================================================================== > --- head/stand/efi/libefi/efi_console.c Tue Jul 17 21:18:49 2018 (r336430) > +++ head/stand/efi/libefi/efi_console.c Tue Jul 17 21:45:14 2018 (r336431) > @@ -147,20 +147,20 @@ efi_cons_rawputchar(int c) > switch (c) { > case '\r': > curx = 0; > - curs_move(&curx, &cury, curx, cury); > + efi_cons_efiputchar('\r'); > return; > case '\n': > + efi_cons_efiputchar('\n'); > + efi_cons_efiputchar('\r'); > cury++; > - if (cury >= y) { > - efi_cons_efiputchar('\n'); > + if (cury >= y) > cury--; > - } else > - curs_move(&curx, &cury, curx, cury); > + curx = 0; > return; > case '\b': > if (curx > 0) { > + efi_cons_efiputchar('\b'); > curx--; > - curs_move(&curx, &cury, curx, cury); > } > return; > default: > @@ -175,7 +175,6 @@ efi_cons_rawputchar(int c) > cury--; > } > } > - curs_move(&curx, &cury, curx, cury); > #endif > } > } >