From owner-freebsd-hackers Sat Apr 5 12:56:26 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id MAA27178 for hackers-outgoing; Sat, 5 Apr 1997 12:56:26 -0800 (PST) Received: from peedub.gj.org (newpc.muc.ditec.de [194.120.126.33]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id MAA27172 for ; Sat, 5 Apr 1997 12:56:21 -0800 (PST) Received: from peedub.gj.org (localhost [127.0.0.1]) by peedub.gj.org (8.8.5/8.6.9) with ESMTP id WAA13307 for ; Sat, 5 Apr 1997 22:56:30 GMT Message-Id: <199704052256.WAA13307@peedub.gj.org> X-Mailer: exmh version 2.0gamma 1/27/96 To: freebsd-hackers@freefall.FreeBSD.org Subject: Re: ipfilter build system complete Reply-To: Gary Jennejohn In-reply-to: Your message of "Sun, 06 Apr 1997 06:01:18 +1000." <19970405200118.20081.qmail@suburbia.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 05 Apr 1997 22:56:30 +0000 From: Gary Jennejohn Sender: owner-hackers@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk proff@suburbia.net writes: > >I've finished writing the build (and module loading) system for >ipfilter. A few other other code changes were also necessarily. >The patches (only about 30k) are available from GNATS as `kern/3207'. >wollman/DG/avalon, can you review this for me? > Great ! The only comment I have right off the bat is that including osreldate.h doesn't work if you're trying to compile ipfilter into the kernel. So, I think ipfconf.h should look like: #ifdef __FreeBSD__ # if defined(KERNEL) # ifndef _KERNEL # define _KERNEL # endif # if __FreeBSD__=3 # define __FreeBSD_version 300000 # endif # if __FreeBSD__=2 # define __FreeBSD_version 220000 # endif # else # include # endif #endif this isn't absolutely correct, unfortunatley, since it doesn't handle 2.1.X. For that we'd need to use BSD from param.h, but ipconf.h gets included much too soon for that. --- Gary Jennejohn Home - Gary.Jennejohn@munich.netsurf.de Work - gjennejohn@frt.dec.com