From owner-svn-src-all@freebsd.org Tue Apr 3 21:00:55 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 72934F80235; Tue, 3 Apr 2018 21:00:55 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 9D07D7456D; Tue, 3 Apr 2018 21:00:54 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id 3T2rfpnmqXziT3T2tfmlhI; Tue, 03 Apr 2018 15:00:47 -0600 X-Authority-Analysis: v=2.3 cv=X6B81lbe c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=Kd1tUaAdevIA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=VOjm7XU_MTT69P80fhcA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id 8CAFF975; Tue, 3 Apr 2018 14:00:45 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id w33L0jp2024505; Tue, 3 Apr 2018 14:00:45 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id w33L0i5g024502; Tue, 3 Apr 2018 14:00:44 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201804032100.w33L0i5g024502@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Konstantin Belousov cc: Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r331943 - head/include In-Reply-To: Message from Konstantin Belousov of "Tue, 03 Apr 2018 23:40:57 +0300." <20180403204057.GM1774@kib.kiev.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 03 Apr 2018 14:00:44 -0700 X-CMAE-Envelope: MS4wfIzt9iEVNe6270h+fKaVMX2JOAEcT2ed2QyRG9FEZffvHQQDX0yPIc5K4KACjhd790vEnxgt0MHeGNbP/uF6R1Kk8sFtFXmwyCt6EDrJ0bA8pMBZOQcd II3hgGAZRCpy4iUELPOASZDYd6F1IkiIt1CuEblEQWncYfX+7KxnEAfFi3zHvx9V2lAfs50Skxv19L3sgQDKzGwoJPvkciuMezpwbYc2cX3ExBXeKGlJ/Nu6 +El7XJxyp5hjLyaadMSUDQERn5k2bAokMTo7YFIQsM2/zafYKJ6G2P8IXTfMu04mqBr8/JLxN2yVuzUQD0xBSQ== X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 21:00:55 -0000 In message <20180403204057.GM1774@kib.kiev.ua>, Konstantin Belousov writes: > On Tue, Apr 03, 2018 at 08:14:37PM +0000, Cy Schubert wrote: > > Author: cy > > Date: Tue Apr 3 20:14:37 2018 > > New Revision: 331943 > > URL: https://svnweb.freebsd.org/changeset/base/331943 > > > > Log: > > Include update to stdio.h missed in r331936. > > > > In my attempt to limit the commit in r331936 to only the gets_s() > > commit and not include unrelated patches in my tree, this patch > > was missed. > > > > Reported by: pfg > > MFC after: 2 weeks > > X-MFC with: r331936 > > Differential Revision: https://reviews.freebsd.org/D12785 > > > > Modified: > > head/include/stdio.h > > > > Modified: head/include/stdio.h > > =========================================================================== > === > > --- head/include/stdio.h Tue Apr 3 19:51:23 2018 (r331942) > > +++ head/include/stdio.h Tue Apr 3 20:14:37 2018 (r331943) > > @@ -51,6 +51,11 @@ typedef __size_t size_t; > > #define _SIZE_T_DECLARED > > #endif > > > > +#ifndef _RSIZE_T_DEFINED > > +#define _RSIZE_T_DEFINED > > +typedef size_t rsize_t; > > +#endif > > + > > #if __POSIX_VISIBLE >= 200809 > > #ifndef _OFF_T_DECLARED > > #define _OFF_T_DECLARED > > @@ -265,6 +270,9 @@ size_t fwrite(const void * __restrict, size_t, size_t > > int getc(FILE *); > > int getchar(void); > > char *gets(char *); > > +#if defined(__EXT1_VISIBLE) && __EXT1_VISIBLE == 1 > What is the purpose of the __EXT1_VISIBLE == 1 check ? > It is against the intended __XX_VISIBLE mechanism construction. That appears to have been left over in my commit tree. > > > +char *gets_s(char *, rsize_t); > > +#endif > > void perror(const char *); > > int printf(const char * __restrict, ...); > > int putc(int, FILE *); -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.