From owner-freebsd-current Sat Apr 27 17: 1:51 2002 Delivered-To: freebsd-current@freebsd.org Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by hub.freebsd.org (Postfix) with ESMTP id 518BD37B416 for ; Sat, 27 Apr 2002 17:01:47 -0700 (PDT) Received: by elvis.mu.org (Postfix, from userid 1920) id 1EBA1AE2D8; Sat, 27 Apr 2002 17:01:47 -0700 (PDT) Date: Sat, 27 Apr 2002 17:01:47 -0700 From: Maxime Henrion To: current@FreeBSD.org Cc: Peter Wemm Subject: Re: Recent commit to sys/kern/kern_environment.c broke reading tunables Message-ID: <20020428000146.GB63621@elvis.mu.org> References: <20020427205753.1F69938FD@overcee.wemm.org> <20020427230829.970ED38FD@overcee.wemm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020427230829.970ED38FD@overcee.wemm.org> User-Agent: Mutt/1.3.27i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Peter Wemm wrote: > This turned out to be part of the problem. I committed your patch and > another followup that got the rest of it. The outstanding problems were: > 1) checkmethod caused use_kenv to be set only once and the next time it > was called, use_kenv would stay at zero and static hints only got used. > 2) the termination of the kenvp[] loop could do a null deref. > > Anyway, I've committed both your and my changes, it should be working now. > If anybody else sees problems still, please yell. Thanks for taking the time to fix this. I was unavailable the whole day and tried to see what was causing the problem quickly this morning, but I expected this to not be sufficient, and it indeed wasn't :-). Cheers, Maxime To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message