From nobody Thu May 15 01:50:09 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZyY7P6Jj7z5w92W; Thu, 15 May 2025 01:50:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZyY7P5N0Zz3CSP; Thu, 15 May 2025 01:50:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747273809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0OJ+vdmncnIU9+SoAWycAcHEbkHW7CpsBElir+L/LAI=; b=KPPbYHvOqWNxt+9EMcUFcmjCDm9iXvufF3ThUM0XSHLYLkyts9ys4UK9RKY6xul6wL1VrV ysn7uO8q0uLJ98o+m0ISe9FZeFEVZmjj8nmsSPudAffYoh3ueyAeNpf38GyCmArDuCpWB+ G6+DqHUlrxs1HVTihOvc7ZIMMsVrF8TuD1H9BJjE4k25LX+VMWYOBdqfrINJE8TRAqh01m I47qnGYSqyO70DldK7froGk/lmjIZ8Pc48N4CbpS06F7nbLV0Ik/5PEnK8H7BNXU/q0BOX nWheL6fKXqD9kmwu8/qSd9fbvHo+9DOCn/Y5d95IWV8cQ5cTOJJsb7epg8EYvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747273809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0OJ+vdmncnIU9+SoAWycAcHEbkHW7CpsBElir+L/LAI=; b=oMLLCTPxGOGKQy2KO1KOnxlAWagBx8VBdwIvxx6MW8wV/ft5WbZz9ih4P81xw2bxcThrSL u8OnPFXCs6z9u6YA6lrw3gYXTiIG3q3Qiow85i9Lq/FIdGtVkv4pf8/XGhu3Mu/TPngnSa 8TZbMb7OyotOjgaEJofN92Rukuo5b+jvmBpZbxJxpwP11J4Mt+kGkhNoRYipjOjHKsi1uY 4CNpSIFoB+OTK8UWk6cusX3SyPrzNb1wbNupzuFwFTIxPEh/BDDNlSykgDT27+F+L5CklX +RlnmZ+UW6E2nlGZQNqXu3UUuJS2phhfqwwOcazUaT+yzsK5hvyQs1c6rAXRNQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1747273809; a=rsa-sha256; cv=none; b=sUCJy/bSxfTIXGo4feDhnyRv1Iv+nxUobhUwMw4WlL3FtGmXglELRjsV0avj6DNuP64CCU ifGWFdY3TIBVAjVIRfsLQmdrycCHBcCy/6z0Ac1+oH72vcgBOfbGwb+emH1Dgzhu5Bot3H GJcnE34NZ+0W8G2EPSP2YMsJvHhGFLlklypm0cW0OFL+dm62D61nh///Df9RAQSOIJ/LWv BVokHNESyrDQS2yfDsV4NAl/oG/T5bBjSGqTPieL4rztrQcpUoMjpNjVgD2qIgFrECNhPW rsqJHjxnbDqxB0Eskyu1FuNUve0LbpoBtAZCIWET447+7eKvlEhTV9XX3HZ4Sw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZyY7P4ngGzxkW; Thu, 15 May 2025 01:50:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 54F1o94q039346; Thu, 15 May 2025 01:50:09 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 54F1o93v039341; Thu, 15 May 2025 01:50:09 GMT (envelope-from git) Date: Thu, 15 May 2025 01:50:09 GMT Message-Id: <202505150150.54F1o93v039341@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Justin Hibbits Subject: git: 45d585ab7f22 - stable/14 - powerpc: Always use BE tag in nexus_map_resource List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhibbits X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 45d585ab7f222ca36988c406df528128a17f9884 Auto-Submitted: auto-generated The branch stable/14 has been updated by jhibbits: URL: https://cgit.FreeBSD.org/src/commit/?id=45d585ab7f222ca36988c406df528128a17f9884 commit 45d585ab7f222ca36988c406df528128a17f9884 Author: Justin Hibbits AuthorDate: 2025-05-13 01:35:14 +0000 Commit: Justin Hibbits CommitDate: 2025-05-15 01:38:24 +0000 powerpc: Always use BE tag in nexus_map_resource 7b5a5e4e replaced nexus_activate_resource() with the bus generic equivalent, which uses bus_map_resource(). However, though not intended to have a functional change, nexus_map_resource() uses the bus tag of the build (BE vs LE), while nexus_activate_resource() always explicitly set a big-endian tag, leading to failures on powerpc64le now. Using BE unless otherwise explicitly specified with the RF_LITTLEENDIAN fixes LE on bare metal, and doesn't hurt in a VM, which nexus_map_resource() was added for. Reported by: pkubaj Tested by: pkubaj Fixes: 7b5a5e4e("powerpc nexus: Use bus_generic_rman_*") MFC after: 1 day (cherry picked from commit c4921a0faaf1683f39347dd066000d929c39c8b9) --- sys/powerpc/powerpc/nexus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/powerpc/powerpc/nexus.c b/sys/powerpc/powerpc/nexus.c index 826e75daa374..b40bb26fd395 100644 --- a/sys/powerpc/powerpc/nexus.c +++ b/sys/powerpc/powerpc/nexus.c @@ -289,7 +289,7 @@ nexus_map_resource(device_t bus, device_t child, int type, struct resource *r, if ((rman_get_flags(r) & RF_LITTLEENDIAN) != 0) map->r_bustag = &bs_le_tag; else - map->r_bustag = nexus_get_bus_tag(NULL, NULL); + map->r_bustag = &bs_be_tag; map->r_size = length; map->r_bushandle = (bus_space_handle_t)map->r_vaddr; break;