From owner-svn-src-head@FreeBSD.ORG  Tue Jan  1 19:49:52 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
 by hub.freebsd.org (Postfix) with ESMTP id 7A2709BC;
 Tue,  1 Jan 2013 19:49:52 +0000 (UTC)
 (envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
 by mx1.freebsd.org (Postfix) with ESMTP id 471AB8FC13;
 Tue,  1 Jan 2013 19:49:52 +0000 (UTC)
Received: from [192.168.2.119]
 (host86-129-88-139.range86-129.btcentralplus.com [86.129.88.139])
 by cyrus.watson.org (Postfix) with ESMTPSA id DDC9746B39;
 Tue,  1 Jan 2013 14:49:50 -0500 (EST)
Subject: Re: svn commit: r244899 - head/sys/mips/beri
Mime-Version: 1.0 (Apple Message framework v1283)
Content-Type: text/plain; charset=us-ascii
From: "Robert N. M. Watson" <rwatson@FreeBSD.org>
In-Reply-To: <20130102081746.5435db05@fubar.geek.nz>
Date: Tue, 1 Jan 2013 19:49:48 +0000
Content-Transfer-Encoding: quoted-printable
Message-Id: <E0592D53-543F-41B7-A141-01CB40669337@FreeBSD.org>
References: <201212311106.qBVB6chM016661@svn.freebsd.org>
 <20130102081746.5435db05@fubar.geek.nz>
To: Andrew Turner <andrew@fubar.geek.nz>
X-Mailer: Apple Mail (2.1283)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Jan 2013 19:49:52 -0000


On 1 Jan 2013, at 19:17, Andrew Turner wrote:

>> @@ -76,6 +85,17 @@ mips_init(void)
>> {
>> 	int i;
>>=20
>> +#ifdef FDT
>> +#ifndef FDT_DTB_STATIC
>> +#error	"mips_init with FDT requires FDT_DTB_STATIC"
>> +#endif
>> +
>> +	if (OF_install(OFW_FDT, 0) =3D=3D FALSE)
>> +		while (1);
>> +	if (OF_init(&fdt_static_dtb) !=3D 0)
>> +		while (1);
>> +#endif
>> +
>> 	for (i =3D 0; i < 10; i++) {
>> 		phys_avail[i] =3D 0;
>> 	}
>>=20
>>=20
>=20
> This looks like it is too late in the boot process. If you are using
> FDT you will need to use the FDT uart which is initialised in cninit.

Hi Andrew:

The current BERI low-level UART, as with several others in MIPS-space, =
has excessively intimate knowledge of the location of the console UART =
instance. Once we fix the console driver, you're right -- it will need =
to move to platform_init() or similar.

> You will also need a patch similar to the untested one attached to fix =
the build.

Thanks -- I had actually committed an identical patch to Perforce this =
morning, but failed to merge it to head. It would be nice if we didn't =
have to conditionally include headers.

Robert=