From owner-freebsd-stable@FreeBSD.ORG Sun Jun 13 04:31:42 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 29C9B106566C for ; Sun, 13 Jun 2010 04:31:42 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 931388FC08 for ; Sun, 13 Jun 2010 04:31:40 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o5D4Vbcw088368 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 13 Jun 2010 07:31:37 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id o5D4VbqR080870; Sun, 13 Jun 2010 07:31:37 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o5D4VbMg080869; Sun, 13 Jun 2010 07:31:37 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 13 Jun 2010 07:31:37 +0300 From: Kostik Belousov To: Rick Macklem Message-ID: <20100613043137.GQ13238@deviant.kiev.zoral.com.ua> References: <20100606144443.GA50876@emmi.physik-pool.tu-berlin.de> <8639wsk4t1.fsf@kopusha.home.net> <20100612141549.GM13238@deviant.kiev.zoral.com.ua> <20100612150915.GN13238@deviant.kiev.zoral.com.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8RsyD0KswhpoK73Z" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-2.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_50, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: Leon Me??ner , freebsd-stable@freebsd.org, Mikolaj Golub Subject: Re: Re: Re: freeBSD nullfs together with nfs and "silly rename" X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jun 2010 04:31:42 -0000 --8RsyD0KswhpoK73Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 12, 2010 at 07:06:11PM -0400, Rick Macklem wrote: >=20 >=20 > On Sat, 12 Jun 2010, Kostik Belousov wrote: >=20 > > > >Yes, I hoped that Mikolaj ends up with something similar :). Please note > >that this is racy, since we cannot know why usecount is greater then 1. > >This might cause the silly rename to kick in some time where it should > >not, but the race is rare. > > > I'd say that having silly rename happen once in a while for unlink when > it doesn't have to happen is better than having the file deleted on the > server while it is still open on the client. My note was not an objection, only a note. Also, when committing, please add a comment explaining what is going on. --8RsyD0KswhpoK73Z Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkwUXygACgkQC3+MBN1Mb4js0gCeJsRxX1aZ6W3pbJHdX6IPUQwH d08Anj8kAqbqzOnzR10swh/VI6sU6r++ =rQWp -----END PGP SIGNATURE----- --8RsyD0KswhpoK73Z--