From owner-svn-ports-all@freebsd.org Wed Sep 28 14:42:39 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9B92DC01A24; Wed, 28 Sep 2016 14:42:39 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (prod2.absolight.net [79.143.243.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 5B0EA1F3; Wed, 28 Sep 2016 14:42:39 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 8BC52BDCDC; Wed, 28 Sep 2016 16:42:36 +0200 (CEST) Received: from ogg.in.absolight.net (ogg.in.absolight.net [79.143.241.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by prod2.absolight.net (Postfix) with ESMTPSA id 1BB04BDCAD; Wed, 28 Sep 2016 16:42:35 +0200 (CEST) Subject: Re: svn commit: r422874 - in head: devel/efl net-mgmt/nsca-ng net-mgmt/zabbix3-server net-mgmt/zabbix32-server www/tomcat-native To: marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201609281347.u8SDls64072549@repo.freebsd.org> <2930934c-272b-50bd-8c7f-d02a7761f92f@marino.st> <662bee21-3341-df4f-ffce-e721a9824519@FreeBSD.org> From: Mathieu Arnold Organization: Absolight / The FreeBSD Foundation Message-ID: <2f090756-71b8-9fe3-cb50-2550a95527ed@FreeBSD.org> Date: Wed, 28 Sep 2016 16:42:33 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="I2oc7hHn9RDfRUv5uR6mLbi1B28eMj0dM" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Sep 2016 14:42:39 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --I2oc7hHn9RDfRUv5uR6mLbi1B28eMj0dM Content-Type: multipart/mixed; boundary="c1f8goJXT8H48MdHf4K36PI0sVmbwPTGl"; protected-headers="v1" From: Mathieu Arnold To: marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <2f090756-71b8-9fe3-cb50-2550a95527ed@FreeBSD.org> Subject: Re: svn commit: r422874 - in head: devel/efl net-mgmt/nsca-ng net-mgmt/zabbix3-server net-mgmt/zabbix32-server www/tomcat-native References: <201609281347.u8SDls64072549@repo.freebsd.org> <2930934c-272b-50bd-8c7f-d02a7761f92f@marino.st> <662bee21-3341-df4f-ffce-e721a9824519@FreeBSD.org> In-Reply-To: --c1f8goJXT8H48MdHf4K36PI0sVmbwPTGl Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le 28/09/2016 =C3=A0 16:38, John Marino a =C3=A9crit : > On 9/28/2016 09:35, Mathieu Arnold wrote: >> Le 28/09/2016 =C3=A0 16:31, John Marino a =C3=A9crit : >>> On 9/28/2016 08:47, Mathieu Arnold wrote: >>>> Author: mat >>>> Date: Wed Sep 28 13:47:53 2016 >>>> New Revision: 422874 >>>> URL: https://svnweb.freebsd.org/changeset/ports/422874 >>>> >>>> Log: >>>> Also, you can't set SSL_DEFAULT, and don't give bad advices to >>>> people, >>>> it should never be set directly, but always through >>>> DEFAULT_VERSIONS. >>>> >>> >>> fair point about setting though DEFAULT_VERSIONS, but it appears to m= e >>> this is purely a semantic policy. From looking at the code, there's >>> no technical issue with setting SSL_DEFAULT instead. It's just doing= >>> it before bsd.default-versions.mk can do exactly the same thing. >>> >>> I'm fine with this "just use DEFAULT_VERSIONS+=3D" policy but I did w= ant >>> to be pedantic that the other way caused no problem. (and is actuall= y >>> more intuitive but that's neither here nor there) >> >> There. can. only. be. one. system-wide. default. >> >> Setting SSL_DEFAULT is the same as setting DEFAULT_VERSIONS in a port,= >> you don't do it, because then, it is not system wide. What started th= is >> is what I fixed in r422872, if you are running 9 with libressl, mysql >> would not build because it would try to install openssl. > > Again, to be pedantic, > I'm talking about /etc/make.conf. > If "DEFAULT_SSL=3Dopenssl" is set the /etc/make.conf, it's system wide.= > It's defined in one spot. > > You fixed those issues correctly. Those were setting in the ports > makefile, which is not the same as setting in make.conf. > > Ok? You agree? Because there is one good way to set defaults, it is with DEFAULT_VERSION= S. https://reviews.freebsd.org/D8060 --=20 Mathieu Arnold --c1f8goJXT8H48MdHf4K36PI0sVmbwPTGl-- --I2oc7hHn9RDfRUv5uR6mLbi1B28eMj0dM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJX69baXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IthEQAIBTa0YmaoH32vBUs+jvwPeu iNHvUzFrXUAKISECM1oKkXqopkQTpFouVAkTzkHAIRs+/OC3a5H2DwjsRfmnp0cC 3kd0gbjvmf7KZpvPaxLaa1kTcvcxU0Z+RadzIqtMm3ZmPw0HhtTOY8l9hM1rjVkF rxYd389d7NaS9l+5Y3qyFKQJMkPi9aVF2hTT1bajwizPpeYydPA4WarA7c6LcWFW rYm9n30GWRwIemOw0NZ1hKP99q6r1I1A3ntgFWI/gsndzEiKYKE2hMCclnfqz40b GyisEGVsAsf3WQ389HQFkfqSkyVwSWCRq9VloYfi/ubJsln9FE9wDmwlUtKWWRXf 1ePvCZO4O/DYwOfwVUucpPkhfknXmBVXvwGAYDF+c1cAjr1yA4sMUJhinoqcqAdf KoieTNCHKg2anhTGam8f8o8cYjrD2SSuJq5hVZh/qpuuQjfCeYO9SSbzG5HxTwFW jhzd1P5+UQ1scbm1Ai8EyMsOdYxJWMNeiYJCwrYbVIor7pBRR1MzUgE47LN9IGNp 06YPKOCTY/h6XTWiQAi09j3tvO/FLso2nqrGkeILkO3t05ClRr1bAQAC2mEkLaJ/ beAEQDePWzEbzv/T4sKW+bJfzU0ZsiSttc9/pQElXTdfKGKJGCK5G1Ifh0bMfs7Z 8sG0hH5GOXtZnio00on8 =TQXy -----END PGP SIGNATURE----- --I2oc7hHn9RDfRUv5uR6mLbi1B28eMj0dM--