From owner-freebsd-commit  Tue Nov 14 00:55:00 1995
Return-Path: owner-commit
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id AAA11950
          for freebsd-commit-outgoing; Tue, 14 Nov 1995 00:55:00 -0800
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id AAA11924
          for cvs-all-outgoing; Tue, 14 Nov 1995 00:54:50 -0800
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id AAA11902
          for cvs-sys-outgoing; Tue, 14 Nov 1995 00:54:42 -0800
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19])
          by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id AAA11864
          ; Tue, 14 Nov 1995 00:54:11 -0800
Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id SAA02115; Tue, 14 Nov 1995 18:47:06 +1100
Date: Tue, 14 Nov 1995 18:47:06 +1100
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199511140747.SAA02115@godzilla.zeta.org.au>
To: bde@zeta.org.au, davidg@Root.COM
Subject: Re: cvs commit: src/sys/nfs nfs_syscalls.c
Cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org
Sender: owner-commit@FreeBSD.org
Precedence: bulk

>>>>  Ifdefed duplicated decentralized declarations of args structs.  It's
>>...
>>>   Now that the definitions are in sysproto.h, I'd like to see them removed
>>>from the .c files.
>>
>>I'm not sure if they should be removed as far as that.  Do you think we
>>should remove the pseudo-declarations from all vnode op functions too?
>>Such declarations are useful iff they are correct.  For examples of
>>possibly harmful incorrect ones, see almost any readdir():

>   The vnode op functions are auto-generated and not really part of the source
>tree. I see syscalls as being different since the delarations are now in a
>standard, centralized place.

Only the VOP* stubs are automatically generated.  Compare rename() with
ufs_rename().  We can retire when ufs_rename() can be automatically
generated :-).

Bruce