Date: Wed, 13 Aug 2025 11:21:39 -0500 From: Kyle Evans <kevans@FreeBSD.org> To: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: babab49eee94 - main - chroot: don't setgroups() without -G having been specified Message-ID: <13572e72-c061-4c89-82e0-0b72bf833cb5@FreeBSD.org> In-Reply-To: <aJwRNpnVc4r9WerN@rincewind.trouble.is> References: <202508121230.57CCUuHn045783@gitrepo.freebsd.org> <aJwRNpnVc4r9WerN@rincewind.trouble.is>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8/12/25 23:14, Philip Paeps wrote: > On 2025-08-12 12:30:56 (+0000), Kyle Evans wrote: >> The branch main has been updated by kevans: >> >> URL: https://cgit.FreeBSD.org/src/commit/? >> id=babab49eee9472f628d774996de13d13d296c8c0 >> >> commit babab49eee9472f628d774996de13d13d296c8c0 >> Author:    Kyle Evans <kevans@FreeBSD.org> >> AuthorDate: 2025-08-12 12:14:38 +0000 >> Commit:    Kyle Evans <kevans@FreeBSD.org> >> CommitDate: 2025-08-12 12:30:23 +0000 >> >>   chroot: don't setgroups() without -G having been specified >> >>   We previously would not have setgroups() at all, but now we would drop >>   our supplementary groups every time. This broke chroot -n, probably >>   among other things. We need tests here, but lets unbreak things >> first. >> >>   A future change may try to setgroups(2) when -u is specified in >> addition >>   to -G, so predicate the call on gidlist and don't populate that >> without >>   a grouplist. >> >>   PR:            288751 >>   Fixes: 48fd05999b0f ("chroot: don't clobber the egid [...]") > > Thank you! > > This made the FreeBSD-kmods builds happy again. :) > Excellent, thanks for confirming! Sorry for the breakage-
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?13572e72-c061-4c89-82e0-0b72bf833cb5>