From owner-freebsd-audit  Thu Jun 20 16:46:38 2002
Delivered-To: freebsd-audit@freebsd.org
Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5])
	by hub.freebsd.org (Postfix) with ESMTP
	id DF75337B411; Thu, 20 Jun 2002 16:46:16 -0700 (PDT)
Received: from hades.hell.gr (patr530-b140.otenet.gr [212.205.244.148])
	by mailsrv.otenet.gr (8.12.3/8.12.3) with ESMTP id g5KNkCMW000788;
	Fri, 21 Jun 2002 02:46:13 +0300 (EEST)
Received: from hades.hell.gr (hades [127.0.0.1])
	by hades.hell.gr (8.12.4/8.12.4) with ESMTP id g5KNkALa001696;
	Fri, 21 Jun 2002 02:46:11 +0300 (EEST)
	(envelope-from keramida@FreeBSD.org)
Received: (from charon@localhost)
	by hades.hell.gr (8.12.4/8.12.4/Submit) id g5KNk7i5001691;
	Fri, 21 Jun 2002 02:46:07 +0300 (EEST)
	(envelope-from keramida@FreeBSD.org)
Date: Fri, 21 Jun 2002 02:45:42 +0300
From: Giorgos Keramidas <keramida@FreeBSD.org>
To: Joachim Str?mbergson <watchman@ludd.luth.se>
Cc: Mike Barcroft <mike@FreeBSD.org>, audit@FreeBSD.org
Subject: Re: Minor change to rusers (Was: Re: minor header change in src/bin/dd/misc.c)
Message-ID: <20020620234542.GA1651@hades.hell.gr>
References: <20020609014512.GA72307@hades.hell.gr> <20020608220030.D87326@espresso.q9media.com> <3D125661.9040704@ludd.luth.se>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3D125661.9040704@ludd.luth.se>
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

On 2002-06-21 00:25 +0000, Joachim Str?mbergson wrote:
>Mike Barcroft wrote:
>> Giorgos Keramidas <keramida@FreeBSD.org> writes:
>>>The source of bin/dd/misc.c doesn't use any of the functions of
>>><strings.h> but uses strlen, which is defined in <string.h>.  The
>>>following seems to fix the only warning this file triggers for me.
>>>Does it seem ok to you all?
>>
>> Yes, it's correct.  <strings.h> is almost always wrong for BSD code.
>> I removed the include of <string.h> from <strings.h> when I cleaned up
>> those headers for POSIX compatibility, so there are probably other
>> mis-includes throughout the system.
>
> It seems that this applies to /usr/bin/rusers too. AFAIK the compilation
> goes through and the behaviour seems to be unaltered. How about this patch?

This is already in -CURRENT.  It can probably me MFC'ed but I don't
have a STABLE machine running the r-series of programs to test this.

Seems OK to me though...

- Giorgos


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message