From owner-freebsd-bugs  Wed Feb 16  4:39:32 2000
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by builder.freebsd.org (Postfix) with ESMTP id 851D643FF
	for <freebsd-bugs@FreeBSD.org>; Wed, 16 Feb 2000 04:39:28 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id EAA76003;
	Wed, 16 Feb 2000 04:40:02 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from isbalham.ist.co.uk (isbalham.ist.co.uk [192.31.26.1])
	by builder.freebsd.org (Postfix) with ESMTP id 3633C42C3
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 16 Feb 2000 04:34:51 -0800 (PST)
Received: (from uucp@localhost)
	by isbalham.ist.co.uk (8.9.2/8.8.7) with UUCP id MAA15850
	for FreeBSD-gnats-submit@freebsd.org; Wed, 16 Feb 2000 12:35:21 GMT
	(envelope-from rb@seagoon.gid.co.uk)
Received: (from root@localhost)
	by seagoon.gid.co.uk (8.9.3/8.9.3) id MAA31001;
	Wed, 16 Feb 2000 12:20:16 GMT
	(envelope-from rb)
Message-Id: <200002161220.MAA31001@seagoon.gid.co.uk>
Date: Wed, 16 Feb 2000 12:20:16 GMT
From: Bob Bishop <rb@seagoon.gid.co.uk>
Reply-To: rb@seagoon.gid.co.uk
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: kern/16745: Kernel Makefile doesn't sanitise PATH [PATCH]
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         16745
>Category:       kern
>Synopsis:       Kernel Makefile doesn't sanitise PATH [PATCH]
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 16 04:40:01 PST 2000
>Closed-Date:
>Last-Modified:
>Originator:     Bob Bishop
>Release:        FreeBSD 3.4-RELEASE i386
>Organization:
GID ltd
>Environment:

	Any

>Description:

	Makefile in /sys/compile/<system> doesn't sanitise
	PATH (cf /usr/src/Makefile).  This can result in wrong
	tools being used.

>How-To-Repeat:

	sh
	echo "echo You must be joking" >/tmp/lex
	chmod +x /tmp/lex
	PATH=/tmp:$PATH export PATH
	cd /sys/i386/conf
	config GENERIC
	cd ../../compile GENERIC
	make depend; make

>Fix:

Something along the lines of:
	
--- /sys/i386/conf/Makefile.i386.orig  Wed Feb 16 12:13:07 2000
+++ /sys/i386/conf/Makefile.i386       Wed Feb 16 12:13:44 2000
@@ -19,6 +19,8 @@
 # Which version of config(8) is required.
 %VERSREQ=      300009

+PATH=   /sbin:/bin:/usr/sbin:/usr/bin
+
 KERNFORMAT?=   elf

 STD8X16FONT?=  iso


>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message