From owner-svn-src-all@FreeBSD.ORG  Wed Oct 15 03:38:44 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id AC04940F;
 Wed, 15 Oct 2014 03:38:44 +0000 (UTC)
Received: from mail-ie0-x22d.google.com (mail-ie0-x22d.google.com
 [IPv6:2607:f8b0:4001:c03::22d])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 533EB259;
 Wed, 15 Oct 2014 03:38:44 +0000 (UTC)
Received: by mail-ie0-f173.google.com with SMTP id tp5so432383ieb.4
 for <multiple recipients>; Tue, 14 Oct 2014 20:38:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:from:date:message-id
 :subject:to:cc:content-type;
 bh=8c7thCwSva9R0qUyF4Qepi7BdxMQbbCZRS6rvvFgQe4=;
 b=TGJSc2F+k5qh9xqYdiTNjKtG7krmfWJpwSQVySIwaKVWgDaEBoxCih+hb32vpbG/l3
 DNzUtFieI5mF8Ce/cM86Tfho2JFmszZ3wGHGxdEAb0rqNw8dcSDmjBs/nk7lnLpgodh5
 ANcwrUi6YIKgpEUzA53+M0SyYrArhkOEHWnpsKUBJl06eVn0iL70Mb0eRRq8ycyYw2fX
 mJGgaDGw/pyHE5GoeHe2WVlyvBXnAS7QO4/Y1QuRgpdygUNmSuOpCeljPXuTRppgqnMS
 wNuyh4bJt3Vsx0YuLu7IyxhCA6V99ikm380GwgqxIbrGnAKu+8yeJWWHLFGOUl5nXAuO
 1JKg==
X-Received: by 10.42.87.6 with SMTP id w6mr9102305icl.10.1413344323768; Tue,
 14 Oct 2014 20:38:43 -0700 (PDT)
MIME-Version: 1.0
Sender: carpeddiem@gmail.com
Received: by 10.107.29.132 with HTTP; Tue, 14 Oct 2014 20:38:23 -0700 (PDT)
In-Reply-To: <20141015030455.GC73266@FreeBSD.org>
References: <201410101926.s9AJQRY1049602@svn.freebsd.org>
 <CA+q+Tcpt0zEbgu_LndZb4dzh=xykHvppeykuiG6P9cTJgDGeWw@mail.gmail.com>
 <20141015030455.GC73266@FreeBSD.org>
From: Ed Maste <emaste@freebsd.org>
Date: Tue, 14 Oct 2014 23:38:23 -0400
X-Google-Sender-Auth: TfTbS8wsJ0rNPstqezGpPS0jbSk
Message-ID: <CAPyFy2CDSwLkTtPFj70tw2iuDam3rS4yFNri=pX0w7_58UYMoA@mail.gmail.com>
Subject: Re: svn commit: r272906 - in head/sys: conf libkern netpfil/pf sys
To: Gleb Smirnoff <glebius@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: =?UTF-8?Q?Olivier_Cochard=2DLabb=C3=A9?= <olivier@cochard.me>,
 "George V. Neville-Neil" <gnn@freebsd.org>,
 svn-src-all <svn-src-all@freebsd.org>,
 src-committers <src-committers@freebsd.org>,
 svn-src-head <svn-src-head@freebsd.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Oct 2014 03:38:44 -0000

On 14 October 2014 23:04, Gleb Smirnoff <glebius@freebsd.org> wrote:
>
> Look at results at the end of email. Guess what -j and -m mean. I
> want either proving me doing the test wrong, or backing the change
> out ASAP.

It looks like there is indeed an error in the test:

> h = murmur3_aligned_32((uint32_t *)&key[i],
>   sizeof(struct pf_state_key_cmp)/sizeof(uint32_t),

murmur3's size argument is bytes, not uint32_ts, so the test is only
hashing the first 1/4 of the keys.