Date: Tue, 20 Aug 2013 14:33:05 +0200 From: John Marino <freebsd.contact@marino.st> To: Andrej Zverev <az@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, marino@freebsd.org, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r325041 - head/japanese/eb Message-ID: <52136201.8030107@marino.st> In-Reply-To: <CAD5bB%2BhVqd-is=F2_EteSaH-mF0L45K4MmO2EU6vRaU1f2P2GA@mail.gmail.com> References: <201308201148.r7KBmYcU083251@svn.freebsd.org> <521359E7.2020008@marino.st> <CAD5bB%2BiA3HQ=dHmE5tjkEzcD88oAeBU4nvEqjjNmbjg=ix1P3Q@mail.gmail.com> <52135BDE.9070600@marino.st> <CAD5bB%2BhVqd-is=F2_EteSaH-mF0L45K4MmO2EU6vRaU1f2P2GA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8/20/2013 14:20, Andrej Zverev wrote: > You can investigate this issue. Nothing personal, but I trust our maintainers. > Even if this wrong, port still work with such changes. I can't save world. > > On Tue, Aug 20, 2013 at 4:06 PM, John Marino <freebsd.contact@marino.st> wrote: >> On 8/20/2013 14:02, Andrej Zverev wrote: >>> Well, patch from PR: http://www.freebsd.org/cgi/query-pr.cgi?pr=181205 >>> Not my decision at all. >> >> But if it is suspected to be incorrect, shouldn't it be challenged via >> the PR feedback mechanism rather than just committing it without question? >> >> It's also easily tested (remove gettext from list and turn off NLS >> option and see if it builds). >> >> I won't bet money on it, but this currently looks wrong to me. Fine. I consider this part of the responsibility of "I'll take it", and I know from first hand experience that committers do review patches they receive from maintainers, but yes, I will put this PR on my to-do list to check and possible correct. You know, I had a big discussion on the freebsd-ports about just fully trusting maintainers and having an automated system so trusted maintainers could fix their ports without committer intervention and the result of the conversation is that no maintainer could ever be trusted to that extent. John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52136201.8030107>