From owner-freebsd-bugs@FreeBSD.ORG Tue Apr 12 02:00:23 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 309141065673 for ; Tue, 12 Apr 2011 02:00:23 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id DB00C8FC17 for ; Tue, 12 Apr 2011 02:00:22 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p3C20MNp036654 for ; Tue, 12 Apr 2011 02:00:22 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p3C20MjF036653; Tue, 12 Apr 2011 02:00:22 GMT (envelope-from gnats) Resent-Date: Tue, 12 Apr 2011 02:00:22 GMT Resent-Message-Id: <201104120200.p3C20MjF036653@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Eitan Adler Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EA16D106566B for ; Tue, 12 Apr 2011 01:59:33 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id D6B818FC08 for ; Tue, 12 Apr 2011 01:59:33 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p3C1xXkp061143 for ; Tue, 12 Apr 2011 01:59:33 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p3C1xXcv061142; Tue, 12 Apr 2011 01:59:33 GMT (envelope-from nobody) Message-Id: <201104120159.p3C1xXcv061142@red.freebsd.org> Date: Tue, 12 Apr 2011 01:59:33 GMT From: Eitan Adler To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/156340: [patch] [bsd.port.mk] reaper of the dead: are three variable defintions needed X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Apr 2011 02:00:23 -0000 >Number: 156340 >Category: misc >Synopsis: [patch] [bsd.port.mk] reaper of the dead: are three variable defintions needed >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Apr 12 02:00:22 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Eitan Adler >Release: >Organization: >Environment: >Description: I'm basing this PR entirely on the comment near the definition. I'm able to build ports with this patch. I think an exp-run would be useful "XXX Are these needed here? DESCR was set wrong for a few years >How-To-Repeat: >Fix: Index: bsd.port.subdir.mk =================================================================== RCS file: /home/ncvs/ports/Mk/bsd.port.subdir.mk,v retrieving revision 1.77 diff -u -r1.77 bsd.port.subdir.mk --- bsd.port.subdir.mk 20 Dec 2010 12:23:52 -0000 1.77 +++ bsd.port.subdir.mk 12 Apr 2011 01:38:34 -0000 @@ -50,11 +50,6 @@ MOVEDDIR?= ${PORTSDIR} MOVEDFILE?= MOVED -# XXX Are these needed here? DESCR was set wrong for a few years -MASTERDIR?= ${.CURDIR} -PKGDIR?= ${MASTERDIR} -DESCR?= ${PKGDIR}/pkg-descr - .include "${PORTSDIR}/Mk/bsd.commands.mk" .MAIN: all >Release-Note: >Audit-Trail: >Unformatted: