From nobody Sat Mar 23 15:54:13 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V23fV0VH7z5FHsJ; Sat, 23 Mar 2024 15:54:26 +0000 (UTC) (envelope-from bofh@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V23fT73qvz4jP1; Sat, 23 Mar 2024 15:54:25 +0000 (UTC) (envelope-from bofh@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711209266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fOMruoVVb+DQyXwHskdg0TVZWgi1x2qi49B0eUqe/wM=; b=Kn1qGjWZ3+llerz36T9P43WSC51ui440AeiEXq7edB+9+XiicdWxzWpCxb/rHuq7TMhTSp R7+ei3+43MyQAx3xAt9Bk9zjpX5W2dwnVnS643aTbpGFhOVOnIPsEEKkcUCkh31f8FCzzM vu5SC6ylJ4eZ0Fj5952vzhESGXYrqTu6Q7YUFjphE+/zsVfu8qkjYX9PsMoy8UyFQOMhth u2waQAozJO9I/xd+4NB8xkMaRBdH/ofhE/CDMFmlW9+lgm9LSEahII8S65bYeQlHLaiSd0 qf/aLYhNjG+LMPHUlCE7AJiB+fxStWk7Pk1IpwMcPcBcYFwY2GGZN2i3Gs1W7A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711209266; a=rsa-sha256; cv=none; b=kfH76Og11WEsQEW8KbeB7FKff4Ss4P+3aXX07dIJF8WElzSHnfdedGIE1x5Dx4jIqsuYgO soz0IHjvgRd5KXoZMP9gZUQDLO3ratXcoaU2Phwo1lfpfMf4cMbv/p8ahmoSyUDiEMCzg2 pC8iowe0hFA17VWIJNx7xH0PtDXD6kqvCejPu6gu3PmijId94j34iJXYutmKUj/hZUoVIZ b8Pj3hRaDJmflRINkImIxt96ohAkh9Zj/LUHgNWfQsRuRxXEce65N82tOqrnskWiDvAKp0 DgsnsltmjN8seVwDFvP/E1O9cTr4OgyPRsF5mhabP2drDn9OtKH/Z8A2zSEdhQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711209266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fOMruoVVb+DQyXwHskdg0TVZWgi1x2qi49B0eUqe/wM=; b=iEs9unffVbUez/iEm+GdXzRNutE2hPSbifgnSP2F7FvdV8MN4ABz6DOwq+pdlQSxegk2m+ HN8I7yO7pP5G0lhNLwCNKWx5nirxqyP3Nv8jQDw4XUedGW7JhafV11kYNr7oeCdhHP0CTK CG2TTMXtee5dYJEN21cx7ekPYqJtYxmNjsIk5UB33TdU1TL/PLp38vFi3jM3Zb+mKHTzMh 7dek/DeV+DW/r3u4Itn6KT0uKixh+kRQCjLf/IdaveFCtPxwTrvBIlwcW5e6IQCfd3UmEs huavmdBPdad2/+dtEcwbjQ1nBozL+pWGrT2AYL27TAvG1p0Z5AaXmI5HtSnvPQ== Received: from mx.bofh.network (mx.bofh.network [5.9.249.227]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: bofh/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4V23fT2JMszWjd; Sat, 23 Mar 2024 15:54:25 +0000 (UTC) (envelope-from bofh@freebsd.org) Received: from smtpclient.apple ( [217.117.226.147]) by mx.bofh.network (OpenSMTPD) with ESMTPSA id d831caf7 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Sat, 23 Mar 2024 15:54:24 +0000 (UTC) Content-Type: multipart/signed; boundary="Apple-Mail=_561E7F91-CF57-44BE-B8F3-FC704AEDD3A9"; protocol="application/pgp-signature"; micalg=pgp-sha512 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6.1.1\)) Subject: Re: git: 28472e9722d8 - main - Revert "x11-fonts/noto*: Restructure and update" From: Moin Rahman In-Reply-To: <2567403.0dHE6SNnxz@angua.firefly> Date: Sat, 23 Mar 2024 16:54:13 +0100 Cc: Sunpoet Po-Chuan Hsieh , Gleb Popov , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Message-Id: <2B7512A8-09EC-4A3B-B594-529E9354215E@freebsd.org> References: <202403231404.42NE4baU095633@gitrepo.freebsd.org> <2567403.0dHE6SNnxz@angua.firefly> To: ports-committers X-Mailer: Apple Mail (2.3731.700.6.1.1) --Apple-Mail=_561E7F91-CF57-44BE-B8F3-FC704AEDD3A9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 23, 2024, at 4:38 PM, Tobias C. Berner = wrote: >=20 > Am Samstag, 23. M=C3=A4rz 2024, 15:14:01 CET schrieb Gleb Popov: >> On Sat, Mar 23, 2024 at 5:04=E2=80=AFPM Po-Chuan Hsieh = wrote: >>> The branch main has been updated by sunpoet: >>>=20 >>> URL: >>> = https://cgit.FreeBSD.org/ports/commit/?id=3D28472e9722d808739a4d690f6d803a= 2 >>> b1b8f5f98 >>>=20 >>> commit 28472e9722d808739a4d690f6d803a2b1b8f5f98 >>> Author: Po-Chuan Hsieh >>> AuthorDate: 2024-03-23 14:01:07 +0000 >>> Commit: Po-Chuan Hsieh >>> CommitDate: 2024-03-23 14:01:07 +0000 >>>=20 >>> Revert "x11-fonts/noto*: Restructure and update" >>>=20 >>> This reverts commit 3b128ff9f74b28ada2f475f0b816480b1550e5b8. >>=20 >> It is good manners to explain the reason for reverting when doing it. >> Even better to first talk to the original committer and ask him to = the >> revert. >=20 > Moin moin >=20 > I completely agree. Given that there has been a phabricator review = open for > two months, with you, sunpoet@ as reviewer, this is looking like poor > judgement on your side. >=20 > As arrowd@ points out, you should have commented on the reverted = commit first, > and elaborate your reasoning for a revert. >=20 > Simply reverting the work of others may lead to fewer contributions. = Please > take this into consideration in the future. >=20 >=20 > mfg Tobias To be frank there are two problems here: 1. Being less communicative. However I do not blame sunpoet@ at all for = this. And we the entire community is responsible for this. Jumping into = communication is really tiring and draining of mental health and also = counter-productive. 2. However the major problem I see here is actually the workflow. =46rom = the later commits I am more than sure that he had some local works which = really did not go well with the reverted commit and was difficult to rebase. So = rather than fixing the rebase conflict the commit was reverted so the rest of = the commits can be rebased and pushed. In multiple occasions it has been = mentioned to have more atomic pushes rather than this amount of commits in one go. With my fingers crossed I hope this commit will return with a different patch from sunpoet himself. Kind regards, Moin --Apple-Mail=_561E7F91-CF57-44BE-B8F3-FC704AEDD3A9 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEETfdREoUGjQZKBS+fvbm1phfAvJEFAmX++yVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDRE Rjc1MTEyODUwNjhEMDY0QTA1MkY5RkJEQjlCNUE2MTdDMEJDOTEACgkQvbm1phfA vJFl3g/9GBpvku2/oUo9qGLRdm1HrpoXYigbB6HmDQAuI+c/bFMA9eXWIDPoXkMr w/HdNQFbb9zwUQ8HSg+0Smdz5O0Q5Wb3lKNLkSawGv0Nwdlj3rMCan8IMJk6dQ8p 8B2UgZLZznkVqjOGW+0yAdH+nBhhFbzvUA/PpJ/TwFiswG4h2ydGZz/aNqGj2WiX GFQJ/tyeAGSde6jlnq6gzQ9kqpOxxoBbkvSFXksMnpT9C7qVJWWK/SQV1wGclb9E OCVou/flwXDWMP465J5qh2kuJicqmppubGt0g4BJo6XahgCWRhpmNL2oJovCJ2nq pI6q0WKWjtA8Qmi5jmESKQK529iJYIFX+HbIV7dotJXcsmxFP1CFaxX7cnB/fuos 1xEHDQeDsWeS4xeLqlKao6Y3wOsZkDonackEYSyfJijNT+3Pdo8FVSosBR8u46ny MhoeNS7oMf+ri30BZ4E44iK5+FjnlBfKWrpbj2JNbCK1XRQhI1i0YI+4TUMsBDAU hbZykkSGd67KCnyuLiwPOdi7URfU53wBq0U2fDYb/o5UWZiZjsRzT7Lcm5j3iQZ4 nqF7vDpjkvOoWBrWH6TX+uc1QHFSW1PQ126aqqC8YKT6RkGEfLKcCnowitbRuAtr 9EegwbGxdJE4bKDAiZDl6mp2UK/iegJz8lAwt2+ugSvvOPbOJW4= =OFsC -----END PGP SIGNATURE----- --Apple-Mail=_561E7F91-CF57-44BE-B8F3-FC704AEDD3A9--