From owner-dev-commits-src-all@freebsd.org Wed Apr 7 21:46:25 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AB9F05C5D5E for ; Wed, 7 Apr 2021 21:46:25 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FFydY490zz4qwD for ; Wed, 7 Apr 2021 21:46:25 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qk1-x72e.google.com with SMTP id g20so193675qkk.1 for ; Wed, 07 Apr 2021 14:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PPukvgcOB36DXlhegJFcqDAW3WFivPt5WEDI1GXUL6o=; b=JC8ICi677Wmh9b3dM7wo+sS+gZf47oeT7EwnMUajNiU35IL7vCUYvgLeeauWBnJk/l tKM+qPjgE4ir0QL6pY/kLxgl1UGsiQBSoslChkNUUWwMrGQxkQJ0AEsC8F0OMmY4mDyt pcUc4pqrFxTdDm/lhx9VsOMl81uBsVpO3jHxgmtXPKpmZ9viHX+gsRyVq6F1in6fdsSL RGmPOdae+Ht+RwMscIabPBLgzsEuNP4F6lygYgL7Czl7qrBx8Shzeiyphm8vwlGCK7J9 boSgiWAQBB0O3DnAIHxW2sfj0SmQYvTqrB1DSoc7RzEqmZJGeeYhnXEDFR/bTAwHPnrO U/8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PPukvgcOB36DXlhegJFcqDAW3WFivPt5WEDI1GXUL6o=; b=CWXUD7Sxpbuk+l8QYMIFJ+CucKQwnxIGUubIkH7/Gxz1xElelU/61bpIKVwEGZFhAX /gO7i/UdDybTMkzQ/RhUKstgVPBw9E8Bk9AF48j22ljtoju0E/3kQwWDmGg3SY/Mxn4H 3h4ikEJTO+2QZwD+mFzTB3v8b5eUIVD+mGdUoVDuFsAnYQtZ0VLRpCQUEm8XUOvGxnls aqoOrFGNaWdeJLHrk3AS+liL9ppaRbZirEFVqPi9bzOuhdjI4YDeRWwGHuVvpqnTAOBS AFIMzSk2klohp/XXYas+QzzR6KvilCxfArq+/9S97f57YVAaJc0WzV+tmdR0jrzN+I1r hUvw== X-Gm-Message-State: AOAM532LO6zt+pj5QrGtNG33xJLqbKoyzakuSFWBRtcILmRB/m6HFZf5 4BOaNDJCyci9WlQhq4Ai8WUENQ== X-Google-Smtp-Source: ABdhPJx8r5UiZqr1YBjFKPyzSAdD38VNgjFe4SdxdXqxJAlZy6AdqaC01Rw1FtfE1UxSp6WQyzQzbQ== X-Received: by 2002:a05:620a:718:: with SMTP id 24mr5434030qkc.121.1617831984121; Wed, 07 Apr 2021 14:46:24 -0700 (PDT) Received: from mutt-hbsd (pool-100-16-222-53.bltmmd.fios.verizon.net. [100.16.222.53]) by smtp.gmail.com with ESMTPSA id w78sm19395934qkb.11.2021.04.07.14.46.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Apr 2021 14:46:23 -0700 (PDT) Date: Wed, 7 Apr 2021 17:46:22 -0400 From: Shawn Webb To: Vincenzo Maffione Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 15dc713ceb57 - main - netmap: vtnet: add support for netmap offsets Message-ID: <20210407214622.gsedn2cuuj7mblq2@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 14.0-CURRENT-HBSD FreeBSD 14.0-CURRENT-HBSD X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <202104072142.137LgrJC015011@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="c75qflhphftjc4ew" Content-Disposition: inline In-Reply-To: <202104072142.137LgrJC015011@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4FFydY490zz4qwD X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Apr 2021 21:46:25 -0000 --c75qflhphftjc4ew Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey Vincenzo, On Wed, Apr 07, 2021 at 09:42:53PM +0000, Vincenzo Maffione wrote: > The branch main has been updated by vmaffione: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D15dc713ceb57d0d61c1dc54b1d= 550da42d250730 >=20 > commit 15dc713ceb57d0d61c1dc54b1d550da42d250730 > Author: Vincenzo Maffione > AuthorDate: 2021-04-07 21:32:20 +0000 > Commit: Vincenzo Maffione > CommitDate: 2021-04-07 21:32:20 +0000 >=20 > netmap: vtnet: add support for netmap offsets > =20 > Follow-up change to a6d768d845c173823785c71bb18b40074e7a8998. > This change adds support for netmap offsets. > --- > sys/dev/netmap/if_vtnet_netmap.h | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) >=20 > diff --git a/sys/dev/netmap/if_vtnet_netmap.h b/sys/dev/netmap/if_vtnet_n= etmap.h > index a05781255218..a423e71331be 100644 > --- a/sys/dev/netmap/if_vtnet_netmap.h > +++ b/sys/dev/netmap/if_vtnet_netmap.h > @@ -84,12 +84,14 @@ vtnet_netmap_txsync(struct netmap_kring *kring, int f= lags) > for (; nm_i !=3D head; nm_i =3D nm_next(nm_i, lim)) { > /* we use an empty header here */ > struct netmap_slot *slot =3D &ring->slot[nm_i]; > + uint64_t offset =3D nm_get_offset(kring, slot); > u_int len =3D slot->len; > uint64_t paddr; > void *addr =3D PNMB(na, slot, &paddr); > int err; > =20 > - NM_CHECK_ADDR_LEN(na, addr, len); > + (void)addr; What is this change for? Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --c75qflhphftjc4ew Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmBuKCwACgkQ/y5nonf4 4fqgEg/8CrYlJhESq1xULuYK7ejRkNXLyHJuZA7Urto41g8itB7JDB/wbneI9Prt SUmPDix+mG26MdSHAOF1b3pLRFNqK02fxuToxZAtR3WlyBcEuUDDVFRCF16Ev2u4 FrpJri0YX30r6C/AVIK1qYJnOw/6JQp9ocGkg4g3dYbgPsr6Zr0rbRhSfUoKKG1F bNBg0mPoRsAjFRL+2P39vSaipiH8l7coWmMScdvy3o85YxmcdiguMOC5X41TAUdi 8F73xn4OaNqd/TW6N12dFuUrok17ePwzaNwiqM1BfChkBb9IofKCC3JtgQCOv9I5 xpSY1gkOYDwHzpOYUOSj43JUwdwXTKvLEmhAiY3+Hi+MWO9cBPXSiHZzSZvEDSYn GiEP5oVaI50LtETTcIbQrNzMyF9kz81tTF80Mf57lUAyvfwNgLz9ClB9WB8elBY2 jr+QfTRE4OmLLWszq8meWoPmVOA7Vdn6jeHnsXWtsVkgCPvKNf5Vd5YdlhaxH+MW N+A6axfEmo/xvJJbQX5frYEmPqojuCr2uwX/JOiJQgqpz1hDLqQOP21lGD5CWf8r EaKBAM4UoDoPVTHDHRdweYOPa5L9earuev4/9cRnfodvaEXNhPX/O21MMKFqf1yG Rxf2XAj5kwDf3sehXg/prN8WM/bA4W+SeGI0dK2u2Qo8KXtE8k4= =h+2Y -----END PGP SIGNATURE----- --c75qflhphftjc4ew--