From owner-cvs-all@FreeBSD.ORG  Tue Dec  7 00:19:46 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id C172D16A4CE; Tue,  7 Dec 2004 00:19:46 +0000 (GMT)
Received: from cs.rice.edu (cs.rice.edu [128.42.1.30])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 891A643D2D; Tue,  7 Dec 2004 00:19:46 +0000 (GMT)
	(envelope-from alc@cs.rice.edu)
Received: from localhost (calypso.cs.rice.edu [128.42.1.127])
	by cs.rice.edu (Postfix) with ESMTP id 154DF4A9BA;
	Mon,  6 Dec 2004 18:19:46 -0600 (CST)
Received: from cs.rice.edu ([128.42.1.30])
 by localhost (calypso.cs.rice.edu [128.42.1.127]) (amavisd-new, port 10024)
 with LMTP id 11503-01-79; Mon,  6 Dec 2004 18:19:45 -0600 (CST)
Received: by cs.rice.edu (Postfix, from userid 19572)
	id B26234A9A4; Mon,  6 Dec 2004 18:19:45 -0600 (CST)
Date: Mon, 6 Dec 2004 18:19:45 -0600
From: Alan Cox <alc@cs.rice.edu>
To: Nate Lawson <nate@root.org>
Message-ID: <20041207001945.GW16680@cs.rice.edu>
References: <20041206004349.8F02916A581@hub.freebsd.org>
	<41B3DE9E.3080307@root.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <41B3DE9E.3080307@root.org>
User-Agent: Mutt/1.4.2i
X-Virus-Scanned: by amavis-20030616-p7 at cs.rice.edu
cc: Alan Cox <alc@FreeBSD.org>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/conf files src/sys/kern kern_subr.c
	uipc_jumbo.c src/sys/pci if_ti.c src/sys/sys jumbo.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Dec 2004 00:19:46 -0000

On Sun, Dec 05, 2004 at 08:22:54PM -0800, Nate Lawson wrote:
> Alan Cox wrote:
> >alc         2004-12-06 00:43:40 UTC
> >
> >  FreeBSD src repository
> >
> >  Modified files:
> >    sys/conf             files 
> >    sys/kern             kern_subr.c 
> >    sys/pci              if_ti.c 
> >  Removed files:
> >    sys/kern             uipc_jumbo.c 
> >    sys/sys              jumbo.h 
> >  Log:
> >  Update the Tigon 1 and 2 driver to use the sf_buf API for implementing
> >  zero-copy receive of jumbo frames.  This eliminates the need for the
> >  jumbo frame allocator implemented in kern/uipc_jumbo.c and sys/jumbo.h.
> >  Remove it.
> >  
> >  Note: Zero-copy receive of jumbo frames did not work without these 
> >  changes;
> >  I believe there was insufficient locking on the jumbo vm object.
> >  
> >  Tested by: ken@
> >  Discussed with: gallatin@
> >  
> >  Revision  Changes    Path
> >  1.973     +0 -1      src/sys/conf/files
> >  1.93      +4 -6      src/sys/kern/kern_subr.c
> >  1.12      +0 -254    src/sys/kern/uipc_jumbo.c (dead)
> >  1.98      +23 -15    src/sys/pci/if_ti.c
> >  1.6       +0 -59     src/sys/sys/jumbo.h (dead)
> 
> Excellent, thanks for doing this.  Having a generic zero-copy API was 
> something we had needed for a long time.  Perhaps cam_periph_mapmem() 
> (sys/cam/cam_periph.c) could also benefit?

Vmapbuf() is still probably the best method for cam_periph_mapmem().
A limitation of the sf_buf interface is that it cannot map two or more
physical pages to contiguous virtual pages.  Vmapbuf() does. 

Regards,
Alan