From owner-svn-src-all@FreeBSD.ORG Wed Apr 29 19:54:54 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8BA14106564A; Wed, 29 Apr 2009 19:54:54 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from mail36.syd.optusnet.com.au (mail36.syd.optusnet.com.au [211.29.133.76]) by mx1.freebsd.org (Postfix) with ESMTP id F25718FC1E; Wed, 29 Apr 2009 19:54:53 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from server.vk2pj.dyndns.org (c122-106-216-167.belrs3.nsw.optusnet.com.au [122.106.216.167]) by mail36.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id n3TJsnYo014716 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 30 Apr 2009 05:54:51 +1000 X-Bogosity: Ham, spamicity=0.000000 Received: from server.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by server.vk2pj.dyndns.org (8.14.3/8.14.3) with ESMTP id n3TJsnIL006759; Thu, 30 Apr 2009 05:54:49 +1000 (EST) (envelope-from peter@server.vk2pj.dyndns.org) Received: (from peter@localhost) by server.vk2pj.dyndns.org (8.14.3/8.14.3/Submit) id n3TJsnj0006758; Thu, 30 Apr 2009 05:54:49 +1000 (EST) (envelope-from peter) Date: Thu, 30 Apr 2009 05:54:49 +1000 From: peterjeremy@optushome.com.au To: Tim Kientzle Message-ID: <20090429195449.GA6715@server.vk2pj.dyndns.org> References: <200904271914.n3RJEhBn024041@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UlVJffcvxoiEqYs2" Content-Disposition: inline In-Reply-To: <200904271914.n3RJEhBn024041@svn.freebsd.org> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.19 (2009-01-05) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r191586 - head/lib/libarchive X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2009 19:54:59 -0000 --UlVJffcvxoiEqYs2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2009-Apr-27 19:14:43 +0000, Tim Kientzle wrote: > ino_t varies across platforms; casting (int) here avoids > various pointless complaints. =2E.. >+ if ((int)archive_entry_ino(entry) > 0777777) { But if ino_t is larger than int then truncating it to int will lead to false negatives here. I don't believe there are any systems where ino_t is smaller than int so maybe cast the constant to (ino_t) instead. --=20 Peter Jeremy --UlVJffcvxoiEqYs2 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iEYEARECAAYFAkn4sIkACgkQ/opHv/APuIe96ACgoMy68F8/DiBh2JG93270o76K z/0AnRPx8kJVUvHEphNTpUWiVuXId5LZ =9u62 -----END PGP SIGNATURE----- --UlVJffcvxoiEqYs2--