Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 20 Jul 2020 19:22:16 +0000 (UTC)
From:      Dan Langille <dvl@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r542671 - head/Mk/Scripts
Message-ID:  <202007201922.06KJMGiM003754@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: dvl
Date: Mon Jul 20 19:22:16 2020
New Revision: 542671
URL: https://svnweb.freebsd.org/changeset/ports/542671

Log:
  At present, the policy implemented in Mk/Scripts/qa.sh prevents me
  from adding lang/python, lang/python2, or lang/python3 as a dependency of
  another port. "This is to prevent adding dependencies to meta ports that
  are only there to improve the end user experience." - I build my own packages
  via poudriere. I want to create my own meta-package which has such packages
  as RUN_DEPENDS. It's been suggested that I patch my own copy of the tree.
  This patch moves towards tools, not policy.
  
  This patch allows me to set this variable in a poudriere make.conf file:
  
  QA_ENV+= IGNORE_DEPENDS_BLACKLIST="YES"
  
  Reviewed by:	mat
  Approved by:	portmgr
  Differential Revision:	https://reviews.freebsd.org/D25450

Modified:
  head/Mk/Scripts/qa.sh

Modified: head/Mk/Scripts/qa.sh
==============================================================================
--- head/Mk/Scripts/qa.sh	Mon Jul 20 19:15:41 2020	(r542670)
+++ head/Mk/Scripts/qa.sh	Mon Jul 20 19:22:16 2020	(r542671)
@@ -1020,7 +1020,12 @@ checks="$checks license depends_blacklist pkgmessage r
 ret=0
 cd ${STAGEDIR} || exit 1
 for check in ${checks}; do
-	${check} || ret=1
+	eval check_test="\$IGNORE_QA_$check"
+	if [ -z "${check_test}" ]; then
+		${check} || ret=1
+	else
+		warn "Ignoring $check QA test"
+	fi
 done
 
 exit ${ret}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202007201922.06KJMGiM003754>